[Qt] remove unclean net-detection in ipcParseCommandLine() #4278

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:paymentrequest_no_net_detect changing 1 files +17 −35

Diapolo commented at 7:19 AM on June 3, 2014: none
- remove the net-detection implementation in ipcParseCommandLine() as it will fail if the request itself is damaged or not a payment-request but just a normal bitcoin: URI
- try to send the received payment-request or URI via ipcSendCommandLine() directly to a mainnet instance and if that fails to a testnet instance (this should reflect normal use case of Bitcoin Core, but will cause problems when running both nets and playing with testnet stuff as the mainnet instance wont process the testnet stuff and error out)

[Qt] remove unclean net-detection in ipcParseCommandLine()

- remove the net-detection implementation in ipcParseCommandLine() as it
  will fail if the request itself is damaged or not a payment-request but
  just a normal bitcoin: URI
- try to send the received payment-request or URI via ipcSendCommandLine()
  directly to a mainnet instance and if that fails to a testnet instance
  (this should reflect normal use case of Bitcoin Core, but will cause
  problems when running both nets and playing with testnet stuff as the
  mainnet instance wont process the testnet stuff and error out)

c71093d23b

Diapolo cross-referenced this on Jun 3, 2014 from issue Enforce strict parsing of network names in payment request processing by rnicoll
BitcoinPullTester commented at 7:39 AM on June 3, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c71093d23b21c4cee998834294c23da3a2c0c464 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 5:31 PM on June 10, 2014: none

@laanwj I remember you didn't like this, right? If true just close it :).
Diapolo closed this on Jun 11, 2014
Diapolo deleted the branch on Jun 11, 2014
laanwj commented at 9:05 AM on June 11, 2014: member

@Diapolo I don't like that it breaks the case in which you run both a testnet and mainnet instance. I'm fine with cleanups but they shouldn't break functionality.
bitcoin locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester

laanwj

Linked (view graph)

#4275 Enforce strict parsing of network names in payment request processing