Fixed comparison in rpcprotocol. #4179

pull kyshank wants to merge 1 commits into bitcoin:master from kyshank:patch-1 changing 1 files +1 −1

kyshank commented at 9:19 PM on May 12, 2014: none

Should be logical OR instead of logical AND.

Fixed comparison in rpcprotocol.

Should be logical OR instead of logical AND.

9930111a53

luke-jr commented at 9:40 PM on May 12, 2014: member

No, it shouldn't...
leofidus commented at 9:40 PM on May 12, 2014: none

pretty sure this change is wrong. Those are not-equal signs. http_method is not "GET" OR http_method is not "POST" would always be true, as it can't be both at the same time.
kyshank commented at 9:56 PM on May 12, 2014: none

Whoops, you're right. My bad. I'm looking for an RPC bug that's causing trouble with some software of mine.
kyshank closed this on May 12, 2014
kyshank deleted the branch on May 12, 2014
BitcoinPullTester commented at 11:29 PM on May 12, 2014: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/9930111a53c4f87e18a61c09115ac1427bbd143c for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
bitcoin locked this on Sep 8, 2021

Contributors