qt: Do proper boost::path conversion #3935

pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2014_03_qt_unicode_path changing 3 files +52 −6
  1. laanwj commented at 9:55 AM on March 22, 2014: member

    Convert from QString unicode from/to the OS-dependent locale as used by boost::filesystem::path as needed.

    This should make data directories with special characters in Windows work.

    Should solve #3916 and #3905.

    Test builds (windows) can be found here: https://download.visucore.com/bitcoin/bitcoin-2014_03_qt_unicode_path_v3.zip Signature: https://download.visucore.com/bitcoin/bitcoin-2014_03_qt_unicode_path_v3.zip.sig

  2. laanwj cross-referenced this on Mar 22, 2014 from issue Windows problem with datadir with unicode chars by laanwj
  3. laanwj commented at 10:37 AM on March 22, 2014: member

    Seems the appropriate conversion function don't even exist yet in the boost used by the pulltester.

    guiutil.cpp:36:58: error: boost/filesystem/detail/utf8_codecvt_facet.hpp: No such file or directory
guiutil.cpp:58: error: ‘utf8_codecvt_facet’ in namespace ‘boost::filesystem::detail’ does not name a type

    Probably needs some boost::filesystem version #ifdefs...

  4. qt: Do proper boost::path conversion
    Convert from QString unicode from/to the OS-dependent locale
as used by boost::filesystem::path as needed.

Solves #3916.
    7e591c19e7
  5. qt: Only override -datadir if different from the default
    Fixes #3905.
    c61fe44194
  6. BitcoinPullTester commented at 8:46 AM on March 25, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c61fe44194ea6d549adfe9ae944ce6fa3a467e0f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  7. laanwj cross-referenced this on Mar 25, 2014 from issue datadir= doesn't function in conf file (Qt GUI) by darkhosis
  8. laanwj referenced this in commit f284b5998a on Mar 26, 2014
  9. laanwj merged this on Mar 26, 2014
  10. laanwj closed this on Mar 26, 2014
  11. laanwj deleted the branch on Apr 9, 2014
  12. laanwj cross-referenced this on May 29, 2014 from issue Sanity-check command line parameters format by kostaz
  13. ken2812221 cross-referenced this on Sep 13, 2018 from issue utils: Make fs::path::string() always return utf-8 string on Windows by ken2812221
  14. bitcoin locked this on Sep 8, 2021
Contributors
laanwjBitcoinPullTester
Linked (view graph)
#3905 datadir= doesn't function in conf file (Qt GUI)#3916 Windows problem with datadir with unicode chars#4194 Sanity-check command line parameters format#13877 utils: Make fs::path::string() always return utf-8 string on Windows
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC