[QT] Fixes feel when resizing the last column on tables (issue #2862) #3920

pull gubatron wants to merge 1 commits into bitcoin:master from gubatron:QT-issue-2862-fix-tables-last-column-resize-feel changing 6 files +217 −27
  1. gubatron commented at 6:00 AM on March 21, 2014: contributor

    Re-submitting this pull request with a single commit.

    This patch introduces a GUIUtil class that is used when setting up the 2 tables we have so far on the Qt-GUI. In the past you could only resize the last column, which has BTC amounts from the right border of the column header, something that was rather unnatural.

    If a new table were ever to be added to the interface, fixing the last columns resizing behavior is rather simple. Just look at how we initialize here a TableViewLastColumnResizingFixer object when setting up the table header's behavior, and then how we override the resize event of the component (can be the table, or the dialog) and we invoke columnResizingFixer->stretchColumnWidth(columnIndex);

    When the window is resized, the second to last column is stretched like before, this was the last fix done.

    Video demoing fix here: https://www.youtube.com/watch?v=rkcPO1sLGX8&feature=youtu.be

  2. [QT] Fixes feel when resizing the last column on tables (issue #2862)
    Re-submitting this pull request with a single commit.
    
    This patch introduces a GUIUtil class that is used when setting up the 2 tables we have so far on the Qt-GUI.
    In the past you could only resize the last column, which has BTC amounts from the right border of the column header, something that was rather unnatural.
    
    If a new table were ever to be added to the interface, fixing the last columns resizing behavior is rather simple. Just look at how we initialize here a TableViewLastColumnResizingFixer object when setting up the table header's behavior, and then how we override the resize event of the component (can be the table, or the dialog) and we invoke columnResizingFixer->stretchColumnWidth(columnIndex);
    8c29273ff0
  3. BitcoinPullTester commented at 6:13 AM on March 21, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/8c29273ff058f90dfa16a30b3d8457b842c0954d for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  4. laanwj referenced this in commit 733a799218 on Mar 21, 2014
  5. laanwj merged this on Mar 21, 2014
  6. laanwj closed this on Mar 21, 2014

  7. Diapolo cross-referenced this on Mar 21, 2014 from issue [Qt] fix style, formating, comment and indentation problems by Diapolo
  8. gubatron deleted the branch on Jul 5, 2014
  9. MathyV referenced this in commit 666dd34bf6 on Oct 27, 2014
  10. hebasto cross-referenced this on Jan 31, 2021 from issue Drop buggy TableViewLastColumnResizingFixer class by hebasto
  11. MarcoFalke referenced this in commit fd725c2d79 on Feb 22, 2021
  12. sidhujag referenced this in commit c7a0f8cbd4 on Feb 22, 2021
  13. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC