getMerchant() appears to check the signature, but getMerchant() caller appears to ignore the result? Testing seems to indicate it makes no matter if payment request signature is invalid or missing.
BIP 70 payment request signatures not checked #3628
issue jgarzik opened this issue on February 5, 2014-
jgarzik commented at 2:38 PM on February 5, 2014: contributor
-
laanwj commented at 3:13 PM on February 5, 2014: member
You mean it still shows the payment request in green if the signature is invalid or missing?
-
jgarzik commented at 3:22 PM on February 5, 2014: contributor
Zero negative indication back to the user, if the sig is missing or invalid.
- laanwj added the label Bug on Feb 5, 2014
- laanwj added the label GUI on Feb 5, 2014
-
laanwj commented at 4:00 PM on February 5, 2014: member
Sounds like a bug...
-
Diapolo commented at 6:25 PM on February 16, 2014: none
@gavinandresen Can you re-work your https://bitcoincore.org/~gavin/createpaymentrequest.php to allow selecting an invalid cert. I'm currently looking into a fix for this. Should IMHO be tagged as medium.
- Diapolo cross-referenced this on Feb 16, 2014 from issue [Qt] ensure BIP70 certificate problems are shown to user by Diapolo
- laanwj added the label Priority Medium on Feb 16, 2014
-
laanwj commented at 11:15 AM on May 18, 2015: member
The payment protocol has been used successfully for a while, including signed payment requests (for which the merchant name is shown). Should be fixed.
- laanwj closed this on May 18, 2015
- sidhujag referenced this in commit eaeb8ab95b on Jul 28, 2020
- bitcoin locked this on Sep 8, 2021
