refactor: prune unused semi-colons #36268

pull fanquake wants to merge 4 commits into bitcoin:master from fanquake:extra_semicolons changing 67 files +103 −101
  1. fanquake commented at 9:58 AM on September 16, 2026: member

    Enable -Wextra-semi and delete all the redundant semicolons.

    Waiting on a pull of the libmultiprocess subtree.

  2. DrahtBot added the label Refactoring on Sep 16, 2026
  3. DrahtBot commented at 9:58 AM on September 16, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #36598 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36598.svg"></sub> ([Demo] validation: remove AssumeUTXO by l0rinc)
    • #36572 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36572.svg"></sub> (ipc: hold event loop references when using it in CapnpProtocol by xyzconstant)
    • #36167 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36167.svg"></sub> ([RFC] Enable -Wunused by fanquake)
    • #35387 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/35387.svg"></sub> (logging: make trace logging easily usable by ryanofsky)
    • #35355 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/35355.svg"></sub> (Use atomics for determining whether trace logging is enabled by ajtowns)
    • #35302 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/35302.svg"></sub> (Silent Payments: Sending (take 2) by Eunovo)
    • #34909 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/34909.svg"></sub> (wallet, refactor: modularise wallet by extracting out legacy wallet migration by rkrux)
    • #34038 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/34038.svg"></sub> (logging: replace -loglevel with -trace, expose trace logging via RPC by ajtowns)
    • #31507 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/31507.svg"></sub> (build: Use clang-cl to build on Windows natively by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. fanquake force-pushed on Sep 16, 2026
  5. DrahtBot added the label CI failed on Sep 16, 2026
  6. DrahtBot commented at 10:21 AM on September 16, 2026: contributor

    <!--85328a0da195eb286784d51f73fa0af9-->

    🚧 At least one of the CI tasks failed. <sub>Task lint: https://github.com/bitcoin/bitcoin/actions/runs/35082380885/job/104749176904</sub> <sub>LLM reason (✨ experimental): CI failed the lint “subtree” check because a subtree directory was modified without a corresponding subtree merge.</sub>

    <details><summary>Hints</summary>

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

    </details>

  7. DrahtBot added the label Needs rebase on Sep 22, 2026
  8. fanquake force-pushed on Sep 29, 2026
  9. DrahtBot removed the label Needs rebase on Sep 29, 2026
  10. fanquake force-pushed on Sep 30, 2026
  11. DrahtBot added the label Needs rebase on Oct 3, 2026
  12. fanquake force-pushed on Oct 3, 2026
  13. DrahtBot removed the label Needs rebase on Oct 3, 2026
  14. DrahtBot added the label Needs rebase on Oct 20, 2026
  15. [nomerge] libmultiprocess fixups
    These will be pulled in with the next subtree update.
    750041b49e
  16. refactor: prevent trailing semi warning on TRACEPOINT_SEMAPHORE c6deb0a327
  17. refactor: remove redundant semicolons 0d1a5e8ba2
  18. build: add -Wextra-semi to warn flags 2a58b6ec12
  19. fanquake force-pushed on Oct 21, 2026
  20. DrahtBot removed the label Needs rebase on Oct 21, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-30 09:40 UTC