wallet rpc: fix stale argument metadata and help text #36264

pull MrHodlX wants to merge 3 commits into bitcoin:master from MrHodlX:rpc-wallet-help-text-fixes changing 4 files +8 −8
  1. MrHodlX commented at 3:15 PM on September 15, 2026: none

    Small fixes to stale argument metadata and help text in the wallet RPCs, in three focused commits:

    1. 5fcbbf8 — listtransactions: the "Negative from" error references the skip argument by its old name
    2. 9aa8977 — listsinceblock: name the failing argument when target_confirmations < 1 instead of a bare "Invalid parameter"
    3. f214b2c — sendmany: the help examples pass values in the ignored minconf position; describe what the example actually sets and pass null for the placeholder

    Required test updates ride in each commit. (Two earlier commits touching deprecated arguments were dropped per maflcko's review: either that deprecated argument gets a proper removal cycle later, or it isn't worth touching.)

  2. DrahtBot commented at 3:16 PM on September 15, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #36384 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36384.svg"></sub> (rpc: Use self.Arg<_>(name) helper over manual and duplicate parsing by maflcko)
    • #36339 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36339.svg"></sub> (wallet: avoid int overflow in listtransactions by kriss39)
    • #36167 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36167.svg"></sub> ([RFC] Enable -Wunused by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. l0rinc commented at 11:26 PM on September 15, 2026: contributor

    Could you please split the related fixes into commits, explaining them briefly in the commit message, describing the problem at a high level and explaining the chosen solution. The changes seem unrelated; by grouping them into focused commits, we can selectively review the suggestion instead of accepting or rejecting all of it.

  4. wallet rpc: name the skip argument in the listtransactions error
    The listtransactions error for a negative skip said "Negative from",
referencing the argument by its old name. The argument has been called
skip in the help for years; say "Negative skip".")
    5fcbbf8352
  5. wallet rpc: name the failing argument in listsinceblock
    listsinceblock rejected target_confirmations < 1 with a bare
"Invalid parameter", not saying which argument was wrong. Name it,
matching the neighboring "Invalid start_height" error.")
    9aa8977c02
  6. wallet rpc: fix the misleading sendmany example
    The sendmany example claimed to set "the confirmation" by passing a
value in the minconf position, but minconf is an ignored dummy, so the
example taught a no-op. Describe what the example actually sets (the
comment) and pass null for the ignored placeholder in both examples.")
    f214b2c9fe
  7. bitcoin deleted a comment on Sep 16, 2026
  8. MrHodlX commented at 12:10 PM on September 16, 2026: none

    Fair point — this commit only makes the marker consistent while the argument exists. A real deprecation/removal cycle (with the OBJ_NAMED_PARAMS type update) can be a follow-up PR rather than expanding the scope here.

  9. DrahtBot added the label CI failed on Sep 18, 2026
  10. DrahtBot removed the label CI failed on Sep 18, 2026
  11. DrahtBot added the label Needs rebase on Oct 19, 2026
  12. DrahtBot commented at 2:13 PM on October 19, 2026: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.

Contributors
MrHodlXDrahtBotl0rinc
Labels
Needs rebase
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-30 09:40 UTC