. #36115

pull gotaku3737-sketch wants to merge 4 commits into bitcoin:master from gotaku3737-sketch:master changing 2 files +16 −4
  1. gotaku3737-sketch commented at 1:45 PM on August 28, 2026: none

    .

  2. ⚡ Bolt: Optimize HexStr conversion with uint16_t packing
    Co-authored-by: gotaku3737-sketch <244136235+gotaku3737-sketch@users.noreply.github.com>
    3a1946c30b
  3. 🛡️ Sentinel: [HIGH] Fix fail-open enum checking in network processing
    🚨 Severity: HIGH
    💡 Vulnerability: Explicit equality checks for `ReadStatus` enum error states in `net_processing.cpp` create a fail-open risk. If the enum expands with new error states, the check bypasses the severe failure handling and allows invalid state to propagate.
    🎯 Impact: Potentially allows maliciously crafted or unhandled compact blocks to bypass network safety bounds (e.g., `Misbehaving()`), risking denial of service or network state desynchronization.
    🔧 Fix: Replaced explicit equality error checks with negated success state checks (`if (status != READ_STATUS_OK)`) and safely fallback to treating unrecognized states as severe errors.
    ✅ Verification: Evaluated the unit tests in `./build/bin/test_bitcoin` and ran the standard repository linter.
    
    Co-authored-by: gotaku3737-sketch <244136235+gotaku3737-sketch@users.noreply.github.com>
    80d0f7e18b
  4. Merge pull request #91 from gotaku3737-sketch/bolt-hexstr-opt-6380933905062601067
    ⚡ Bolt: Optimize HexStr conversion with uint16_t packing
    86bf6861c8
  5. Merge pull request #92 from gotaku3737-sketch/sentinel-fail-open-enum-11348317328314482777
    🛡️ Sentinel: [HIGH] Fix fail-open enum checking in network processing
    9dfeb8fab3
  6. DrahtBot commented at 1:45 PM on August 28, 2026: contributor

    LLM spam detection (✨ experimental): SPAM. The submission contains only boilerplate contributor guidance and no actual description of the proposed change, rationale, fixes, tests, or implementation details, making it a placeholder/empty PR rather than a legitimate contribution.

    ♻️ Automatically wiping, closing, and locking for now based on heuristics. Generally, please focus on creating high-quality, original content that demonstrates a clear understanding of the project's requirements and goals.

  7. DrahtBot renamed this:
    Optimize HexStr conversion and fix fail-open enum checks
    .
    on Aug 28, 2026
  8. DrahtBot closed this on Aug 28, 2026

  9. bitcoin locked this on Aug 28, 2026
  10. DrahtBot commented at 1:45 PM on August 28, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36115.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-09 07:56 UTC