refactor: Enforce iwyu on src/init #36104

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2608-iwyu-init changing 8 files +9 −4
  1. maflcko commented at 4:58 PM on August 27, 2026: member

    This PR continues the ongoing effort to enforce IWYU warnings.

    See Developer Notes.

  2. refactor: Bump old copyright header in univalue
    Noted in the last iwyu PR: https://github.com/bitcoin/bitcoin/pull/35900#pullrequestreview-5040554983
    fa1d342350
  3. DrahtBot renamed this:
    refactor: Enforce iwyu on src/init
    refactor: Enforce iwyu on src/init
    on Aug 27, 2026
  4. DrahtBot added the label Refactoring on Aug 27, 2026
  5. DrahtBot commented at 4:58 PM on August 27, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36104.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  6. maflcko force-pushed on Aug 27, 2026
  7. DrahtBot added the label CI failed on Aug 27, 2026
  8. DrahtBot commented at 5:14 PM on August 27, 2026: contributor

    <!--85328a0da195eb286784d51f73fa0af9-->

    🚧 At least one of the CI tasks failed. <sub>Task i686, no IPC: https://github.com/bitcoin/bitcoin/actions/runs/33095983783/job/98600895025</sub> <sub>LLM reason (✨ experimental): CI failed due to a C++ build error: bitcoin-wallet.cpp fails to compile because std::unique_ptr is used with incomplete types (interfaces::Node/Chain/...), causing invalid application of sizeof to incomplete type.</sub>

    <details><summary>Hints</summary>

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

    </details>

  9. refactor: Enforce iwyu on src/init
    This also triggers an edit on interfaces/init.h and ipc.h
    face38d4b0
  10. maflcko force-pushed on Aug 27, 2026
  11. maflcko commented at 5:28 PM on August 27, 2026: member

    All of those are passing locally for me. Not sure what is different about my setup that this fails CI. Closing for now. Someone else can pick this up.

  12. maflcko closed this on Aug 27, 2026

  13. maflcko deleted the branch on Aug 27, 2026
  14. hebasto commented at 7:25 PM on August 27, 2026: member

    All of those are passing locally for me. Not sure what is different about my setup that this fails CI. Closing for now. Someone else can pick this up.

    Picked in #36107.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-09 07:56 UTC