Use std::system_category().message(err) on non-Windows, which internally dispatches to strerror_r, and should handle unknown errors.
See: https://github.com/llvm/llvm-project/blob/4e9e83400a5702059c8a18e2fb6174038875e8a6/libcxx/src/system_error.cpp#L231-L237 for one standard library implementation.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
6 | @@ -7,9 +7,8 @@ 7 | 8 | #include <string> 9 | 10 | -/** Return system error string from errno value. Use this instead of 11 | - * std::strerror, which is not thread-safe. For network errors use 12 | - * NetworkErrorString from sock.h instead. 13 | +/** Return system error string from errno value. For network errors 14 | + * use NetworkErrorString from sock.h instead.
/// Return system error string from errno value. For network errors
/// use NetworkErrorString from sock.h instead.
nit: The different indent looks a bit ugly? Could use a fixed-size doxygen comment?
Sure, changed.
Dropped any Windows-specific changes here.
22 | - /* Too bad there are three incompatible implementations of the 23 | - * thread-safe strerror. */ 24 | - const char *s = nullptr; 25 | -#ifdef WIN32 26 | - if (strerror_s(buf, sizeof(buf), err) == 0) s = buf; 27 | -#else
Is it safe to remove this Windows-specific code?
Really removed any Windows related changes.
Use std::system_category().message(err), which internally dispatches to
strerror_r, and should handle unknown errors.
See: https://github.com/llvm/llvm-project/blob/4e9e83400a5702059c8a18e2fb6174038875e8a6/libcxx/src/system_error.cpp#L231
<!--85328a0da195eb286784d51f73fa0af9-->
🚧 At least one of the CI tasks failed.
<sub>Task lint: https://github.com/bitcoin/bitcoin/actions/runs/39228215016/job/117979614825</sub>
<sub>LLM reason (✨ experimental): CI failed because the locale-dependence lint flagged the strerror_s call in src/util/syserror.cpp.</sub>
<details><summary>Hints</summary>
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
</details>
Use
std::system_category().message(err)on non-Windows, which internally dispatches tostrerror_r, and should handle unknown errors.See: https://github.com/llvm/llvm-project/blob/4e9e83400a5702059c8a18e2fb6174038875e8a6/libcxx/src/system_error.cpp#L231-L237 for one standard library implementation.
In libstdc++, the corresponding change landed in https://github.com/gcc-mirror/gcc/commit/51f94778b45514992a716b0b2d7a87244e6f0018 (GCC 14) and was backported to GCC 13.3, but never to GCC 12. Does it make sense to postpone this change until #36042?
Also
--- a/src/util/syserror.cpp
+++ b/src/util/syserror.cpp
@@ -7,10 +7,12 @@
#include <tinyformat.h>
#include <string>
-#include <system_error>
#if defined(WIN32)
+#include <cstring>
#include <windows.h>
+#else
+#include <system_error>
#endif
std::string SysErrorString(int err)