build: honor CMAKE_INSTALL_LIBEXECDIR in wrapper #36037

pull Avecci-Claussen wants to merge 1 commits into bitcoin:master from Avecci-Claussen:libexecdir-launcher changing 5 files +66 −5
  1. Avecci-Claussen commented at 2:05 PM on August 20, 2026: none

    Fixes #35785

    Internal binaries are installed to CMAKE_INSTALL_LIBEXECDIR. That defaults to libexec, but a distro can set it to something else (Arch uses lib). The bitcoin wrapper always looked in ../libexec under the install prefix, so those builds fail after cmake --install for bitcoin-node, chainstate, and the other internal binaries.

    The wrapper now uses the same CMake value.

    tool_bitcoin.py copies the wrapper into a fake prefix/bin and bitcoind only into prefix/<LIBEXECDIR>, then runs it by absolute path.

    Putting the binary in a different directory should fail. Normal functional tests miss this because every binary sits next to the wrapper in the build tree.

  2. build: honor CMAKE_INSTALL_LIBEXECDIR in wrapper
    The wrapper always looked in ../libexec for binaries, but
    install_binary_component(INTERNAL) uses CMAKE_INSTALL_LIBEXECDIR.
    Distro builds that set that to lib then fail after install.
    Fixes #35785
    1a72400cd5
  3. DrahtBot added the label Build system on Aug 20, 2026
  4. DrahtBot commented at 2:06 PM on August 20, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36037.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #36022 (test: add coverage for bitcoin wrapper argument handling by cyb3ralbert)
    • #32387 (ipc: add windows support by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. DrahtBot added the label CI failed on Aug 22, 2026
  6. DrahtBot commented at 12:10 PM on August 22, 2026: contributor

    <!--85328a0da195eb286784d51f73fa0af9-->

    🚧 At least one of the CI tasks failed. <sub>Task lint: https://github.com/bitcoin/bitcoin/actions/runs/32378100542/job/97015882585</sub> <sub>LLM reason (✨ experimental): CI failed due to a linted commit message format error: the commit subject line wasn’t followed by a blank line before the body.</sub>

    <details><summary>Hints</summary>

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

    </details>

  7. Avecci-Claussen closed this on Aug 22, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-09 07:56 UTC