wallet: fix ignored subtract_fee_from_outputs option #35317

pull stutxo wants to merge 1 commits into bitcoin:master from stutxo:wallet-sffo-snake-case changing 2 files +30 −2
  1. stutxo commented at 1:11 AM on May 19, 2026: contributor

    The shared wallet funding validation accepts subtract_fee_from_outputs, but fundrawtransaction and walletcreatefundedpsbt previously only read subtractFeeFromOutputs when building recipients. This caused the accepted snake_case option to be silently ignored.

    This PR reads either accepted spelling before interpreting subtract-fee outputs, and adds functional coverage for both affected RPCs.

    Tested:

    build/test/functional/test_runner.py wallet_fundrawtransaction.py
    
  2. wallet: fix ignored subtract_fee_from_outputs option
    fundrawtransaction and walletcreatefundedpsbt both type-check the shared subtract_fee_from_outputs option, but previously looked up only subtractFeeFromOutputs when building recipients. This caused the accepted snake_case option to be silently ignored.
    
    Read either accepted spelling before interpreting subtract fee outputs. Add functional coverage for fundrawtransaction and walletcreatefundedpsbt.
    8ed3107c38
  3. DrahtBot added the label Wallet on May 19, 2026
  4. DrahtBot commented at 1:11 AM on May 19, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35317.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:51 UTC