Prevent empty transactions from being added to vtxPrev #3356

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_12_skip_empty_vtxprev changing 1 files +4 −0

laanwj commented at 2:32 PM on December 4, 2013: member

CWalletTx::AddSupportingTransactions() was adding empty transaction to vtxPrev in some cases. Skip over these.

Part one of the solution to #3190. This prevents invalid vtxPrev from entering the wallet, but not current ones being transmitted.

This will need to go into 0.8.6 as well.

Prevent empty transactions from being added to vtxPrev

CWalletTx::AddSupportingTransactions() was adding empty transaction
to vtxPrev in some cases. Skip over these.

Part one of the solution to #3190. This prevents invalid vtxPrev from
entering the wallet, but not current ones being transmitted.

d3ef9b00ec

laanwj cross-referenced this on Dec 4, 2013 from issue Refuse to retransmit transactions without vins by laanwj
BitcoinPullTester commented at 3:13 PM on December 4, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d3ef9b00ecdc9cc449bea073b1ee54a8dcc6aaf1 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
gavinandresen commented at 4:19 AM on December 5, 2013: contributor

ACK
laanwj referenced this in commit b1961523f1 on Dec 5, 2013
laanwj merged this on Dec 5, 2013
laanwj closed this on Dec 5, 2013
laanwj cross-referenced this on Dec 5, 2013 from issue Nodes forwarding transactions with empty vins by TheBlueMatt
laanwj deleted the branch on Apr 9, 2014
bitcoin locked this on Sep 8, 2021

Contributors

laanwj

BitcoinPullTester

gavinandresen

Linked (view graph)

#3190 Nodes forwarding transactions with empty vins #3357 Refuse to retransmit transactions without vins