minor cleanup in CheckBlock #3311

pull lian wants to merge 1 commits into bitcoin:master from lian:minor_cleanup_checkblock changing 1 files +1 −1

lian commented at 2:22 PM on November 23, 2013: contributor

block.vtx.empty() is checked in the "size limits failed" part already. just a couple of lines above in that same function.
lian cross-referenced this on Nov 23, 2013 from issue Minor typo cleanup by lian

minor cleanup in CheckBlock

block.vtx.empty() is checked in the "size limits failed" part already

b90a78d06a

BitcoinPullTester commented at 2:53 PM on November 23, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b90a78d06a705242b5883a3adc0770029b9b1c9d for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 9:20 PM on January 12, 2014: none

IMHO this correct.
sipa commented at 10:53 PM on January 12, 2014: member

It is correct, but it's stupid cheap (perhaps even optimized away), and it makes the code more obviously correct.
laanwj commented at 7:33 AM on January 13, 2014: member

And in this function it's very important to be obviously correct. A bit of defensive programming may be in order, so IMO we should just keep it as it is.
laanwj commented at 11:14 AM on February 24, 2014: member

Closing, as the consensus seems to be to keep this as-is because it is more readable this way.
laanwj closed this on Feb 24, 2014
bitcoin locked this on Sep 8, 2021

Contributors