Remove redundant insert method in serialize #3162

pull sipa wants to merge 1 commits into bitcoin:master from sipa:saninsert changing 1 files +0 −13

sipa commented at 6:42 PM on October 26, 2013: member

This seems to cause problems on recent clang, and looks totally redundant and unused.

The const_iterator version is identical to the vector::const_iterator one (which is a typedef thereof). Marking it private (instead of removing) compiles fine, so this version is effectively unused even.

Remove redundant insert method in serialize.

This seems to cause problems on recent clang, and looks totally
redundant and unused.

The const_iterator version is identical to the vector::const_iterator
one (which is a typedef thereof). Marking it private (instead of
removing) compiles fine, so this version is effectively unused even.

e9755001ab

jgarzik commented at 6:45 PM on October 26, 2013: contributor

ACK
sipa commented at 6:45 PM on October 26, 2013: member

Updated, this will not fix #2806. There is an additional problem with datetime/locale conversion.
sipa cross-referenced this on Oct 26, 2013 from issue OS X 10.9 compile problems by maciej-trebacz
BitcoinPullTester commented at 6:56 PM on October 26, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e9755001ab1b63d205f1e130ffe42b213cb052c6 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 3:50 PM on October 28, 2013: member

ACK
laanwj referenced this in commit cde10602a6 on Oct 29, 2013
laanwj merged this on Oct 29, 2013
laanwj closed this on Oct 29, 2013
wtogami cross-referenced this on Nov 9, 2013 from issue Build error in Mac OS X 10.9 by antanst
wtogami cross-referenced this on Nov 9, 2013 from issue Remove redundant insert method in serialize. by wtogami
freider referenced this in commit aa281aeb32 on Dec 28, 2013
freider cross-referenced this on Dec 29, 2013 from issue Fixes for building on MacOSX 10.9 by freider
cb0 cross-referenced this on Jan 4, 2014 from issue Remove redundant insert method in serialize. by cb0
BetaCoinDev referenced this in commit c497d5ff5f on Apr 11, 2014
BetaCoinDev referenced this in commit 4e342ab683 on Apr 11, 2014
stamhe cross-referenced this on Jun 8, 2014 from issue fixed bitcoin build bug #3162 by stamhe
NoirX referenced this in commit 2429ee26b6 on Jul 14, 2014
Tranz5 referenced this in commit d08447b4e3 on Jul 22, 2014
palmd referenced this in commit 237884df1e on Nov 24, 2014
zencd referenced this in commit b2697edb58 on Jun 14, 2017
iamunick referenced this in commit fc9f5431c0 on Feb 18, 2018
iamunick referenced this in commit f0ceca00c5 on Feb 18, 2018
Bushstar referenced this in commit 33d04ebf28 on Apr 8, 2020
bitcoin locked this on Sep 8, 2021

Contributors

Linked (view graph)

#2806 OS X 10.9 compile problems