Move pMiningKey init out of StartRPCThreads #2716

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_05_30_getwork changing 4 files +21 −10

laanwj commented at 1:56 PM on May 30, 2013: member

This commit decouples the pMiningKey initialization and shutdown from the RPC threads.

getwork and getblocktemplate rely on pMiningKey, and can also be ran from the debug window in the UI even when the RPC server is not running.

Solves issue #2706.

Move pMiningKey init out of StartRPCThreads

This commit decouples the pMiningKey initialization and shutdown from the RPC
threads.

`getwork` and `getblocktemplate` rely on pMiningKey, and can also be ran
from the debug window in the UI even when the RPC server is not running.

Solves issue #2706.

d98bf10f23

in src/init.cpp:None in 513cf67531 outdated
```
1081 | @@ -1081,6 +1082,7 @@ bool AppInit2(boost::thread_group& threadGroup)
1082 |  
1083 |      StartNode(threadGroup);
1084 |  
1085 | +    InitRPCMining();
```
gavinandresen commented at 2:22 PM on May 30, 2013:

Suggest comment: // InitRPCMining is needed here so getwork/getblocktemplate in the GUI debug console works properly.

laanwj commented at 2:42 PM on May 30, 2013:

Added
jgarzik referenced this in commit 6bc6d57303 on May 30, 2013
jgarzik merged this on May 30, 2013
jgarzik closed this on May 30, 2013
laanwj cross-referenced this on May 31, 2013 from issue Bitcoin-Qt debug console crash, getblocktemplate / getwork by gavinandresen
laanwj deleted the branch on Apr 9, 2014
bitcoin locked this on Sep 8, 2021

Contributors

laanwj

gavinandresen

Linked (view graph)

#2706 Bitcoin-Qt debug console crash, getblocktemplate / getwork