miniscript_stable fuzz timeout #27147

1. 
   maflcko commented at 1:00 PM on February 23, 2023: member

   https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=56270

2. maflcko added the label Bug on Feb 23, 2023
3. 
   sipa commented at 3:31 PM on February 23, 2023: member

   Reproduced it. It looks like it's just a giant input (53000 miniscript nodes) that will eventually lead to a too-large script, but the logic is only able to detect this once it's done. I think we can use a technique like the one we used in FromString parsing to detect too-large scripts early. Alternatively (and probably, independently) we can add a node count limit.

4. maflcko added this to the milestone 25.0 on Feb 24, 2023
5. sipa cross-referenced this on Feb 25, 2023 from issue Make miniscript_{stable,smart} fuzzers avoid too large scripts by sipa
6. 
   sipa commented at 9:38 PM on February 25, 2023: member

   See #27165.

7. fanquake closed this on Feb 28, 2023

   ---

8. sidhujag referenced this in commit 6a0ba6180a on Mar 1, 2023
9. 
   fanquake commented at 7:56 PM on March 1, 2023: member

   Verified as fixed: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=56332#c3

10. 
    sipa commented at 8:00 PM on March 1, 2023: member

    @fanquake Wrong issue, actually; the original was about miniscript_stable: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=56270

    The one you link to was about miniscript_smart, but that is in fact also addressed by #27165.

11. 
    fanquake commented at 8:01 PM on March 1, 2023: member

    Wrong issue, actually;

    Whoops. Yes, both ended up being addressed here.

12. bitcoin locked this on Feb 29, 2024

Contributors

maflckosipafanquake

Milestone
25.0