ci: Use clang-15 and IWYU v0.19 in "tidy" task #26766

pull hebasto wants to merge 4 commits into bitcoin:master from hebasto:221228-clang15 changing 25 files +60 −22
  1. hebasto commented at 9:27 PM on December 28, 2022: member

    There was a hope that the new IWYU v0.19 gets rid of the entire contrib/devtools/iwyu/bitcoin.core.imp. Alas...

    Based on #26763.

  2. iwyu: Fix IWYU violations 2c38463803
  3. iwyu, ci: Treat IWYU violations as errors 4a940a5b9e
  4. ci: Use clang-15 and IWYU v0.19 in "tidy" task aa498b78ad
  5. iwyu: Drop backported mappings
    See https://github.com/include-what-you-use/include-what-you-use/pull/1026
    53817c8b5f
  6. DrahtBot commented at 9:27 PM on December 28, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #26859 (fuzz: extend ConsumeNetAddr() to return I2P and CJDNS addresses by vasild)
    • #26850 (ci: Stop and remove CI container by MarcoFalke)
    • #26763 (ci: Treat IWYU violations as errors by hebasto)
    • #26705 (clang-tidy: Check headers and fixes them by hebasto)
    • #25152 (refactor: Split util/system into exception, shell, and fs-specific files by Empact)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. DrahtBot added the label Tests on Dec 28, 2022
  8. fanquake commented at 9:53 PM on December 28, 2022: member

    I don't think we want to hop to non-LTS releases in the CI unless it's really required: #26296 (comment).

  9. hebasto commented at 9:56 PM on December 28, 2022: member

    I don't think we want to hop to non-LTS releases in the CI unless it's really required: #26296 (comment).

    Agree. That's why this PR is a draft for now.

  10. in .cirrus.yml:84 in 53817c8b5f 
      77 | @@ -78,10 +78,10 @@ task:
  78 |      << : *CIRRUS_EPHEMERAL_WORKER_TEMPLATE_ENV
  79 |  
  80 |  task:
  81 | -  name: 'tidy [jammy]'
  82 | +  name: 'tidy [kinetic]'
  83 |    << : *GLOBAL_TASK_TEMPLATE
  84 |    container:
  85 | -    image: ubuntu:jammy
  86 | +    image: ubuntu:kinetic
    maflcko commented at 8:35 AM on December 29, 2022:

    An alternative would be to use https://packages.debian.org/bookworm/clang-15 ?

    maflcko commented at 11:49 AM on March 7, 2023:

    Another alternative would be to use https://apt.llvm.org/

  11. DrahtBot cross-referenced this on Dec 29, 2022 from issue clang-tidy: Fix `modernize-use-default-member-init` in headers and force to check all headers by hebasto
  12. hebasto cross-referenced this on Dec 29, 2022 from issue ci: Move `--enable-c++20` from "tidy" task back to "ASan..." one by hebasto
  13. maflcko referenced this in commit 65de8eeeca on Dec 29, 2022
  14. DrahtBot cross-referenced this on Dec 30, 2022 from issue ci: Treat IWYU violations as errors by hebasto
  15. DrahtBot cross-referenced this on Jan 9, 2023 from issue fuzz: extend ConsumeNetAddr() to return I2P and CJDNS addresses by vasild
  16. DrahtBot cross-referenced this on Jan 11, 2023 from issue refactor: Split util/system into exception, shell, and fs-specific files by Empact
  17. DrahtBot cross-referenced this on Jan 11, 2023 from issue ci: Stop and remove CI container by maflcko
  18. DrahtBot commented at 9:57 PM on January 12, 2023: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.

  19. DrahtBot added the label Needs rebase on Jan 12, 2023
  20. hebasto closed this on Feb 2, 2023
  21. maflcko added the label Up for grabs on Mar 7, 2023
  22. hebasto cross-referenced this on Mar 23, 2023 from issue ci: Use clang-15 in "tidy" task by hebasto
  23. fanquake referenced this in commit f380bb93e8 on Mar 23, 2023
  24. fanquake removed the label Up for grabs on Apr 14, 2023
  25. fanquake removed the label Needs rebase on Apr 14, 2023
  26. fanquake commented at 10:03 AM on April 14, 2023: member

    Removing up for grabs here, as we are now using clang-16 and IWYU 0.20.

  27. hebasto cross-referenced this on May 21, 2023 from issue ci, iwyu: Update mappings by hebasto
  28. bitcoin locked this on Apr 13, 2024
Contributors
hebastoDrahtBotfanquakemaflcko
Labels
Tests
Linked (view graph)
#26763 ci: Treat IWYU violations as errors#26770 ci: Move `--enable-c++20` from "tidy" task back to "ASan..." one#27311 ci: Use clang-15 in "tidy" task#27710 ci, iwyu: Update mappings
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC