When computing tagged-hashes for Schnorr sigs the 3 methods (challenge, aux, nonce) first call secp256k1_sha256_initialize that sets the hashstate (ie. s[0] to s[7] and bytes) to their default SHA256 values then they each immediately change all those values to the precomputed "midstate" values. The first call to secp256k1_sha256_initialize seems wasteful.
Unnecessary call to secp256k1_sha256_initialize #26712
issue Coding-Enthusiast opened this issue on December 16, 2022-
Coding-Enthusiast commented at 2:45 PM on December 16, 2022: none
- Coding-Enthusiast added the label Bug on Dec 16, 2022
-
fanquake commented at 2:49 PM on December 16, 2022: member
This issue would be better opened / reported upstream: https://github.com/bitcoin-core/secp256k1, as the code here is a (semi-regularly updated) subtree of that repository.
- fanquake removed the label Bug on Dec 16, 2022
- Coding-Enthusiast cross-referenced this on Dec 16, 2022 from issue Unnecessary call to secp256k1_sha256_initialize by Coding-Enthusiast
- fanquake closed this on Dec 17, 2022
- bitcoin locked this on Dec 28, 2022
Contributors