refactor: Silence GCC Wmissing-field-initializers in ChainstateManagerOpts #26409

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2210-gcc-🏾 changing 1 files +2 −2

maflcko commented at 9:11 AM on October 28, 2022: member

The std::optional fields in the struct that fall back to chain param defaults if not provided should be initialized to std::nullopt. This already happens with the current code.

However, for consistency with check_block_index and to silence a GCC warning, add the "missing" {}.
refactor: Silence GCC Wmissing-field-initializers in ChainstateManagerOpts fa29ef00ad
maflcko cross-referenced this on Oct 28, 2022 from issue refactor: Remove almost all validation option globals by maflcko
DrahtBot added the label Refactoring on Oct 28, 2022
hebasto approved
hebasto commented at 9:53 AM on October 28, 2022: member

ACK fa29ef00adac6f0842acdd38344820a1ce0e3087, tested on Ubuntu 22.04 + GCC 11.3.
jonatack commented at 5:55 PM on October 28, 2022: contributor

ACK fa29ef00adac6f0842acdd38344820a1ce0e3087

Didn't test building with GCC (with Clang 14 yes) but the changes look correct.
fanquake cross-referenced this on Oct 28, 2022 from issue Initialize optional members of ChainstateManagerOpts to nullopt by achow101
achow101 commented at 7:36 PM on October 28, 2022: member

ACK fa29ef00adac6f0842acdd38344820a1ce0e3087
achow101 merged this on Oct 28, 2022
achow101 closed this on Oct 28, 2022
maflcko deleted the branch on Oct 29, 2022
sidhujag referenced this in commit b323a849eb on Oct 30, 2022
bitcoin locked this on Oct 29, 2023

Contributors

Labels