p2p: TryLowWorkHeadersSync follow-ups #26387

pull dergoegge wants to merge 2 commits into bitcoin:master from dergoegge:2022-10-tlwhs-doc-fixup changing 1 files +6 −11

dergoegge commented at 10:41 AM on October 25, 2022: member

See #26355 (review) and #26355 (review)
[net processing] Fixup TryLowWorkHeadersSync comment e891aabf5a
dergoegge cross-referenced this on Oct 25, 2022 from issue p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started by dergoegge
fanquake added the label Docs on Oct 25, 2022
mzumsande commented at 2:13 PM on October 25, 2022: contributor

utACK e891aabf5a4992a65b9c5ae8606f8dd08515b310
maflcko commented at 3:14 PM on October 25, 2022: member

Maybe also address #26355 (review) ?

[net processing] Simplify use of IsContinuationOfLowWorkHeadersSync in TryLowWorkHeaderSync

`m_headers_sync` is already reset in IsContinuationOfLowWorkHeadersSync
if there is a failure, so there is no need to also reset in
TryLowWorkHeaderSync.

784b023191

dergoegge renamed this:
~~doc: Fixup TryLowWorkHeadersSync comment (#26355 follow-up)~~
p2p: #26355 follow-ups
on Oct 26, 2022
dergoegge commented at 10:16 AM on October 26, 2022: member

Maybe also address #26355 (review) ?

Added a commit for that comment.
hernanmarino approved
hernanmarino commented at 10:59 AM on October 27, 2022: contributor

ACK 784b02319128988038d4bd82f05736be22f14ee9
brunoerg approved
brunoerg commented at 12:06 PM on October 27, 2022: contributor

crACK 784b02319128988038d4bd82f05736be22f14ee9
maflcko renamed this:
~~p2p: #26355 follow-ups~~
p2p: TryLowWorkHeadersSync follow-ups
on Oct 28, 2022
maflcko removed the label Docs on Oct 28, 2022
DrahtBot added the label P2P on Oct 28, 2022
fanquake requested review from mzumsande on Oct 28, 2022
mzumsande commented at 3:24 PM on October 31, 2022: contributor

ACK 784b02319128988038d4bd82f05736be22f14ee9

I checked that IsContinuationOfLowWorkHeadersSync calls ProcessNextHeaders, which sets the state to FINAL if unsuccessful, resulting in IsContinuationOfLowWorkHeadersSync doing the cleanup of m_headers_sync and m_headers_presync_stats, so it is correct to remove the same cleanup in TryLowWorkHeadersSync.
fanquake referenced this in commit 43e813cab2 on Oct 31, 2022
fanquake commented at 3:38 PM on October 31, 2022: member

This has been merged.
fanquake closed this on Oct 31, 2022
sidhujag referenced this in commit 57f8033b7c on Oct 31, 2022
bitcoin locked this on Oct 31, 2023

Contributors

Labels

Linked (view graph)

#26355 p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started