wallet: have prune error take precedence over assumedvalid #26282

pull jamesob wants to merge 1 commits into bitcoin:master from jamesob:2022-10-fix-au-wallet changing 1 files +8 −6

jamesob commented at 7:18 PM on October 7, 2022: member

Fixes #23997 (review).

From Russ Yanofsky:

Agree with all of Marco's points here and think this should be updated

If havePrune and hasAssumedValidChain are both true, better to show havePrune error message. Assumed-valid error message is vague and not very actionable. Would suggest "Error loading wallet. Wallet requires blocks to be downloaded, and software does not currently support loading wallets while blocks are being downloaded out of order though assumeutxo snapshots. Wallet should be able to load successfully after node sync reaches height {block_height}"
jamesob cross-referenced this on Oct 7, 2022 from issue wallet: avoid rescans under assumed-valid blocks by jamesob

wallet: have prune error take precedence over assumedvalid

From Russ Yanofsky:

"Agree with all of Marco's points here and think this should be updated

If havePrune and hasAssumedValidChain are both true, better to show
havePrune error message.  Assumed-valid error message is vague and not
very actionable.  Would suggest "Error loading wallet. Wallet requires
blocks to be downloaded, and software does not currently support loading
wallets while blocks are being downloaded out of order though assumeutxo
snapshots. Wallet should be able to load successfully after node sync
reaches height {block_height}"

Co-authored-by: MacroFake <MarcoFalke@gmail.com>
Co-authored-by: Russ Yanofsky <russ@yanofsky.org>

1c36bafc5f

jamesob force-pushed on Oct 7, 2022
DrahtBot added the label Wallet on Oct 7, 2022
maflcko commented at 7:47 AM on October 10, 2022: member

ACK 1c36bafc5f7db268546dcc86c793071a7e9d35e0
aureleoules approved
aureleoules commented at 8:02 AM on October 10, 2022: member

ACK 1c36bafc5f7db268546dcc86c793071a7e9d35e0
fanquake merged this on Oct 10, 2022
fanquake closed this on Oct 10, 2022
sidhujag referenced this in commit 0ca55f8355 on Oct 10, 2022
jamesob cross-referenced this on Oct 13, 2022 from issue assumeutxo by jamesob
ryanofsky cross-referenced this on Jan 6, 2023 from issue refactor: Use util::Result class for wallet loading by ryanofsky
bitcoin locked this on Oct 10, 2023

Contributors

Labels

Linked (view graph)

#15606 assumeutxo #23997 wallet: avoid rescans under assumed-valid blocks #25722 refactor: Use util::Result class for wallet loading