std::array::at() expects an argument of the size_t type. This PR avoids implicit type conversion (for both 64-bit and 32-bit systems).
Also it enables MSVC warning C4334 for all codebase.
refactor: Make 64-bit shift explicit #26252
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:221004-shift changing 2 files +2 −2-
hebasto commented at 7:14 PM on October 4, 2022: member
- hebasto cross-referenced this on Oct 4, 2022 from issue msvc, refactor: Avoid some rare compiler warnings by hebasto
-
-
DrahtBot commented at 8:19 PM on October 4, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
- DrahtBot added the label Refactoring on Oct 4, 2022
- DrahtBot added the label Needs rebase on Oct 4, 2022
- DrahtBot cross-referenced this on Oct 4, 2022 from issue build, msvc: Enable C4834 warning by hebasto
-
5c5b85d0e7
refactor: Make 64-bit shift explicit
Also this change enables MSVC warning C4334 for all codebase. https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4334
- hebasto force-pushed on Oct 4, 2022
- DrahtBot removed the label Needs rebase on Oct 4, 2022
- MarcoFalke approved
-
MarcoFalke commented at 9:58 AM on October 5, 2022: member
ACK 5c5b85d0e7e7bb6eea47be60e20140b9fa9fa745 🚎
<details><summary>Show signature</summary>
Signature:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 ACK 5c5b85d0e7e7bb6eea47be60e20140b9fa9fa745 🚎 -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p pUjVnAv9FQwGec5u0nG1WliXrLEgomK9sscEUIZ30DPpvI2ILk0Rzz/jhwd8mu30 rj+KOPnedU705XpjhB5BJ57eihBXYQBkCBN6cV0jMs3GsfwKgZqmNMCH9rdDgEWB HxDi+4TW862m9svCZBDdx7V4atS7/VdRX5yA9v1IFaydqF6JFFgHGE1wm/oVH3sv Kci50Lf+iRJxwBb1ejG8kHqbH5Q0SlPTfPChL4YmXC+yd2jfNF4DFzgMfrYfI822 lOjN5oyTiYWKeXBAVp6taEnlP/DyIuFvgozhoT27j578IwviivxSERL9RGAo3zPA HrdGYZqx1F8CxQ1EhzbJltIQeWowRinlnJZ7ATPs0Glb0eUkWJtNZn+wRVvSkmb3 b9xWM73kT/5ilbHWEpJFNMNaVDJOWvWS+DJQkudr6zoS26go4u6bcUthKVFYOtvu F0f2CTDkSqBm8lbNLOMIYTGFLfP4Kih26xYU2Edq4ope5jvU6ICLVGSL5Y09XzxV 9y0qdut2 =/pMJ -----END PGP SIGNATURE-----</details>
-
jonatack commented at 11:48 AM on October 5, 2022: contributor
Code review ACK 5c5b85d0e7e7bb6eea47be60e20140b9fa9fa745
- MarcoFalke merged this on Oct 5, 2022
- MarcoFalke closed this on Oct 5, 2022
- hebasto deleted the branch on Oct 5, 2022
- sidhujag referenced this in commit a880052389 on Oct 5, 2022
- hebasto cross-referenced this on May 2, 2023 from issue refactor: Make 64-bit shift explicit by hebasto
- bitcoin locked this on Oct 5, 2023
