sendall: check if the maxtxfee has been exceeded #26084

pull ishaanam wants to merge 1 commits into bitcoin:master from ishaanam:sendall_maxtxfee changing 2 files +19 −0

ishaanam commented at 12:10 AM on September 14, 2022: contributor

Previously the sendall RPC didn't check whether the fees of the transaction it creates exceed the set maxtxfee. This PR adds this check to sendall and a test case for it.
sendall: check if the maxtxfee has been exceeded 6f8e3818af
ishaanam cross-referenced this on Sep 14, 2022 from issue sendall: check if the maxtxfee has been exceeded by ishaanam
w0xlt commented at 1:11 AM on September 14, 2022: contributor

Approach ACK
DrahtBot commented at 9:24 AM on September 14, 2022: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #26024 (wallet: fix sendall creates tx that fails tx-size check by kouloumos)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
glozow requested review from murchandamus on Sep 14, 2022
glozow added this to the milestone 24.0 on Sep 14, 2022
DrahtBot cross-referenced this on Sep 14, 2022 from issue wallet: fix sendall creates tx that fails tx-size check by kouloumos
glozow commented at 9:57 AM on September 14, 2022: member

Concept ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f. The high feerate is unlikely but sendall should respect the existing wallet options.
brunoerg commented at 2:41 PM on September 14, 2022: contributor

Concept ACK
achow101 commented at 8:48 PM on September 14, 2022: member

ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f
murchandamus commented at 10:30 PM on September 14, 2022: contributor

ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f
MarcoFalke merged this on Sep 15, 2022
MarcoFalke closed this on Sep 15, 2022
sidhujag referenced this in commit 950551f794 on Sep 15, 2022
ishaanam deleted the branch on Sep 15, 2022
bitcoin locked this on Sep 15, 2023