util: improve bitcoin-wallet exit codes #26067

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2209-wallet-exit-🛶 changing 2 files +13 −8

MarcoFalke commented at 11:12 AM on September 12, 2022: member

Refactors bitcoin-wallet so that it doesn't return a non-zero exit code by default, and makes the option handling more inline with the other binaries. i.e outputting Error: too few parameters if you don't pass any options.

Fixing this means we can check the process output in gen-manpages.py; which addresses the remaining review comment from #24263.
util: improve bitcoin-wallet exit codes fa2b8ae0a2
MarcoFalke cross-referenced this on Sep 12, 2022 from issue util: improve bitcoin-wallet exit codes by fanquake
DrahtBot added the label Utils/log/libs on Sep 12, 2022
luke-jr approved
luke-jr commented at 11:25 PM on September 19, 2022: member

utACK
MarcoFalke merged this on Sep 20, 2022
MarcoFalke closed this on Sep 20, 2022
MarcoFalke deleted the branch on Sep 20, 2022
sidhujag referenced this in commit 39caeb411b on Sep 20, 2022
ryanofsky cross-referenced this on Sep 21, 2022 from issue multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky

in contrib/devtools/gen-manpages.py:39 in fa2b8ae0a2

  35 | @@ -36,7 +36,7 @@
  36 |  for relpath in BINARIES:
  37 |      abspath = os.path.join(builddir, relpath)
  38 |      try:
  39 | -        r = subprocess.run([abspath, '--version'], stdout=subprocess.PIPE, universal_newlines=True)
  40 | +        r = subprocess.run([abspath, "--version"], stdout=subprocess.PIPE, check=True, universal_newlines=True)

Riahiamirreza commented at 5:26 PM on September 23, 2022:

Why change single quote to double quote? Is it a coding style in the Bitcoin Core?

Riahiamirreza commented at 5:45 PM on September 23, 2022: contributor

As far as I could grasp the codebase, ACK.
bitcoin locked this on Sep 23, 2023

Contributors

Labels

Linked (view graph)

#19460 multiprocess: Add bitcoin-wallet -ipcconnect option #24263 doc: Fix gen-manpages, rewrite in Python #24428 util: improve bitcoin-wallet exit codes