Fixes #26051
Verify the best blockhash is the same after invalidating an unknown block, not the whole getchaintip response.
test: verify best blockhash after invalidating an unknown block #26054
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2022-09-fix-test-invalidateblock changing 1 files +1 −2-
brunoerg commented at 4:15 PM on September 9, 2022: contributor
- fanquake added the label Tests on Sep 9, 2022
- brunoerg cross-referenced this on Sep 9, 2022 from issue test: invalidating an unknown block throws an error by brunoerg
- brunoerg marked this as ready for review on Sep 9, 2022
-
instagibbs commented at 4:25 PM on September 9, 2022: member
if we're just checking that active tip didn't change, I think a simple
getbestblockhashworks -
brunoerg commented at 4:47 PM on September 9, 2022: contributor
if we're just checking that active tip didn't change, I think a simple getbestblockhash works
I agree. Gonna change it.
-
test: verify best blockhash after invalidating an unknown block 4f67336f11
- brunoerg force-pushed on Sep 9, 2022
- brunoerg renamed this:
test: verify active chaintip after invalidating an unknown block
test: verify best blockhash after invalidating an unknown block
on Sep 9, 2022 -
brunoerg commented at 4:51 PM on September 9, 2022: contributor
Force-pushed addressing @instagibbs's suggestion.
-
instagibbs commented at 4:56 PM on September 9, 2022: member
ACK 4f67336f1105b7c34a9e8cdafa603edc1d899fb9
-
amovfx commented at 6:31 PM on September 9, 2022: none
I reviewed to learn what is going on.
- MarcoFalke merged this on Sep 10, 2022
- MarcoFalke closed this on Sep 10, 2022
- sidhujag referenced this in commit dce770f7ae on Sep 11, 2022
- bitcoin locked this on Sep 10, 2023
