test: apply fixed feerate to avoid variable dynamic fees in wallet_groups.py #25990

pull stickies-v wants to merge 1 commits into bitcoin:master from stickies-v:test-walletgroups-fix-feerate changing 1 files +3 −2

stickies-v commented at 12:30 AM on September 3, 2022: contributor

Without specifying a feerate, we let the wallet decide on an appropriate feerate, which can be influenced by various factors such as what's in the mempool. Since wallet_groups.py fails when feerates are unstable, we should use a fixed feerate across all nodes. The assumed feerate was 20 sats/vbyte, so this PR adopts that.

Closes #25940. I'm not 100% sure, but I think the increased tx relay speed introduced by #25865 caused the transactions to more quickly and often enter the other nodes' mempools, affecting their feerate calculation done in wallet:GetMinimumFeeRate() and thus deviating slightly from the expected 20 sats/vbyte.

Ran wallet_groups.py over 400 times without failure.

test: apply fixed feerate to avoid variable dynamic fees

Without specifying a feerate, we let the wallet decide on an
appropriate feerate, which can be influenced by various factors
such as what's in the mempool. Since wallet_groups.py fails when
feerates are unstable, we should use a fixed feerate across all nodes.

Closes #25940

2186608172

stickies-v cross-referenced this on Sep 3, 2022 from issue Intermittent failure in `wallet_groups.py` by mzumsande
stickies-v cross-referenced this on Sep 3, 2022 from issue test: revert #25865 for wallet_groups.py (quick fix) by stickies-v
DrahtBot added the label Tests on Sep 3, 2022
MarcoFalke added this to the milestone 24.0 on Sep 5, 2022
glozow commented at 4:20 PM on September 8, 2022: member

Approach ACK 2186608172b0e6c3a9907e06fed27dfd927abd45

Based on tx4_ungrouped_fee, etc, it looks like this test assumes the transactions will be constructed at 20sat/vB and thus it makes sense to use -paytxfee to make that always true.
aureleoules commented at 5:25 PM on September 8, 2022: member

ACK 2186608172b0e6c3a9907e06fed27dfd927abd45. Ran several times the test and seems to fix #25940.
MarcoFalke merged this on Sep 9, 2022
MarcoFalke closed this on Sep 9, 2022
stickies-v deleted the branch on Sep 9, 2022
sidhujag referenced this in commit 9bac3956f4 on Sep 11, 2022
bitcoin locked this on Sep 9, 2023

Contributors

Labels

Milestone
24.0

Linked (view graph)

#25865 test: speedup wallet tests by whitelisting peers (immediate tx relay)#25940 Intermittent failure in `wallet_groups.py`#25988 test: revert #25865 for wallet_groups.py (quick fix)