wallet: remove UNKNOWN type from OUTPUT_TYPES array #25869

1. 
   furszy commented at 7:49 PM on August 18, 2022: member

   Fixing #25734 (review) -> https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=50329

   The OUTPUT_TYPES array contain the known active output types only. And it's solely used to create/walk-through the active spkms.

   So, no need to add the UNKNOWN type here.

2. wallet: remove UNKNOWN type from OUTPUT_TYPES array

   This array contains the known active output types only.
   And it's solely used to create/walk-through the active spkms.

   5b4fdbbff5
3. furszy cross-referenced this on Aug 18, 2022 from issue wallet, refactor: #24584 follow-ups by josibake
4. fanquake added the label Wallet on Aug 18, 2022
5. 
   DrahtBot commented at 9:26 PM on August 18, 2022: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24897 ([Draft / POC] Silent Payments by w0xlt)
   • #23417 (wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager by achow101)
   • #22341 (rpc: add getxpub by Sjors)
   • #19602 (wallet: Migrate legacy wallets to descriptor wallets by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. w0xlt approved
7. 
   w0xlt commented at 10:58 PM on August 18, 2022: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/25869/commits/5b4fdbbff527aef8288edb3bf21b478de1061221

8. DrahtBot cross-referenced this on Aug 19, 2022 from issue [Draft / POC] Silent Payments by w0xlt
9. LarryRuane approved
10. 
    LarryRuane commented at 5:19 AM on August 19, 2022: contributor

    ACK 5b4fdbbff527aef8288edb3bf21b478de1061221

11. DrahtBot cross-referenced this on Aug 19, 2022 from issue wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager by achow101
12. DrahtBot cross-referenced this on Aug 19, 2022 from issue rpc: add path to gethdkey by Sjors
13. maflcko added this to the milestone 24.0 on Aug 19, 2022
14. fanquake requested review from achow101 on Aug 19, 2022
15. DrahtBot cross-referenced this on Aug 19, 2022 from issue wallet: Migrate legacy wallets to descriptor wallets by achow101
16. 
    achow101 commented at 3:46 PM on August 19, 2022: member

    ACK 5b4fdbbff527aef8288edb3bf21b478de1061221

17. achow101 merged this on Aug 19, 2022
18. achow101 closed this on Aug 19, 2022

    ---

19. furszy deleted the branch on May 27, 2023
20. bitcoin locked this on May 26, 2024

Review Requested
achow101

Milestone
24.0