This refactor is needed to disable the (potentially expensive for large json) UniValue copy constructors.
scripted-diff: Replace NullUniValue with UniValue::VNULL #25699
pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2207-univalue-types-🙉 changing 13 files +92 −92-
MarcoFalke commented at 3:31 PM on July 25, 2022: member
-
fa962103e8
fuzz: refactor: Replace NullUniValue with UniValue{}
This is needed for the scripted-diff to compile in the next commit
-
fa28d0f3c3
scripted-diff: Replace NullUniValue with UniValue::VNULL
This is required for removing the UniValue copy constructor. -BEGIN VERIFY SCRIPT- sed -i 's/return NullUniValue/return UniValue::VNULL/g' $(git grep -l NullUniValue ':(exclude)src/univalue') -END VERIFY SCRIPT-
- MarcoFalke cross-referenced this on Jul 25, 2022 from issue refactor: Avoid UniValue copies by MarcoFalke
- fanquake added the label Refactoring on Jul 25, 2022
- luke-jr approved
-
luke-jr commented at 4:33 PM on July 25, 2022: member
Ugh @ the diff, but utACK because I can't think of a better solution.
-
DrahtBot commented at 6:21 PM on July 25, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #24170 (p2p, rpc: Manual block-relay-only connections with addnode by mzumsande)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Jul 25, 2022 from issue p2p, rpc: Manual block-relay-only connections with addnode by mzumsande
- fanquake approved
-
fanquake commented at 9:07 AM on July 26, 2022: member
ACK fa28d0f3c3fe528dae7fd6dc7725219b9bdf0e1b
- fanquake merged this on Jul 26, 2022
- fanquake closed this on Jul 26, 2022
- MarcoFalke deleted the branch on Jul 26, 2022
- sidhujag referenced this in commit 3961df67e2 on Jul 27, 2022
- bitcoin locked this on Jul 26, 2023
Contributors
Labels