hebasto
commented at 12:21 PM on July 19, 2022:
member
Concept ACK.
fanquake
commented at 12:29 PM on July 19, 2022:
member
ACK if green tidy. Could also include
rpc/fees.cpp should remove these lines:
- #include <policy/policy.h> // lines 9-9
- #include <util/system.h> // lines 19-19
Remove unused includes from dbwrapper.h1111ddeedf
Remove unused includes in rpc/fees.cpp
IWYU confirms that they are unused
faf98aecf8
MarcoFalke force-pushed on Jul 19, 2022
hebasto approved
hebasto
commented at 12:39 PM on July 19, 2022:
member
ACKfaf98aecf876fae0ec6d4d16b7e66f3a35253180, I have reviewed the code and it looks OK, I agree it can be merged.
DrahtBot
commented at 12:45 PM on July 19, 2022:
contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
#25623 ([kernel 3e/n] Decouple CDBWrapper and CBlockTreeDB from ArgsManager by dongcarl)
#25527 ([kernel 3c/n] Decouple validation cache initialization from ArgsManager by dongcarl)
#25172 (refactor: use std:: prefix for std lib funcs by fanquake)
#24833 (refactor: consensus/tx_verify.{h,cpp} tidy-ups by jonatack)
#24232 (assumeutxo: add init and completion logic by jamesob)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke renamed this: Remove unused includes from dbwrapper.h refactor: Remove unused includes from dbwrapper.h on Jul 19, 2022
DrahtBot added the label Refactoring on Jul 19, 2022
Sjors
commented at 2:51 PM on July 19, 2022:
member
It indeed does look a bit confusing. But I can still build from scratch on macOS 12.4
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC