refactor: Use chainman() helper consistently in ChainImpl #25638

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2207-chainman-🕉 changing 1 files +19 −19

MarcoFalke commented at 8:01 AM on July 19, 2022: member

Doing anything else will just lead to more verbose and inconsistent code.
refactor: Use chainman() helper consistently in ChainImpl fa32b1bbfd
MarcoFalke cross-referenced this on Jul 19, 2022 from issue wallet: avoid rescans under assumed-valid blocks by jamesob
fanquake added the label Refactoring on Jul 19, 2022
jamesob commented at 1:10 PM on July 19, 2022: member

Concept ACK, will review shortly
fanquake approved
fanquake commented at 10:19 AM on July 20, 2022: member

ACK fa32b1bbfd418410c47b2a33c6fa106371288138 - all instances of Assert(m_node.chainman) in node/interfaces replaced with chainman(), which is the same thing.
shaavan approved
shaavan commented at 12:20 PM on July 20, 2022: contributor
Code Review ACK fa32b1bbfd418410c47b2a33c6fa106371288138
- I agree with making the code less verbose while maintaining the same logic behind it.
- Verified that using chainman() is equivalent to Assert(m_node.chainman)
```
ChainstateManager& chainman() { return *Assert(m_context->chainman); }
```
- Verified that all instances of Assert(m_node.chainman) are replaced with chainman().
MarcoFalke merged this on Jul 20, 2022
MarcoFalke closed this on Jul 20, 2022
MarcoFalke deleted the branch on Jul 20, 2022
jonatack cross-referenced this on Jul 20, 2022 from issue refactor: make all NodeImpl/ChainImpl/ExternalSignerImpl members public, rm temporaries, simplify by jonatack
jonatack commented at 4:32 PM on July 20, 2022: contributor

Post-merge ACK
sidhujag referenced this in commit 24fdb06473 on Jul 20, 2022
bitcoin locked this on Jul 20, 2023

Contributors

Labels

Linked (view graph)

#23997 wallet: avoid rescans under assumed-valid blocks #25651 refactor: make all NodeImpl/ChainImpl/ExternalSignerImpl members public, rm temporaries, simplify