move-only: Version handshake to libtest_util #25591

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2207-hand-util-🕷 changing 6 files +75 −55
  1. MarcoFalke commented at 6:45 AM on July 12, 2022: member

    The version handshake after setting up a peer is an integral part of (unit) testing net processing logic.

    Thus, make the helper accessible in libtest_util.

    Also, remove the peerman argument from FillNode, as it must be equal to connman's peerman, which can then be used instead.

  2. move-only: Version handshake to libtest_util fa7098947c
  3. move-only: InitializeNode to handshake helper fa4be8e7c3
  4. MarcoFalke added the label Refactoring on Jul 12, 2022
  5. MarcoFalke added the label Tests on Jul 12, 2022
  6. MarcoFalke cross-referenced this on Jul 12, 2022 from issue net processing: Move CNode::nServices and CNode::nLocalServices to Peer by dergoegge
  7. DrahtBot commented at 7:44 AM on July 12, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25515 ([draft] PeerManager unit tests by dergoegge)
    • #25514 (net processing: Move CNode::nServices and CNode::nLocalServices to Peer by dergoegge)
    • #25284 ([WIP] consensus: Remove dependency on net (BIP 155 / ADDRV2_FORMAT) by MarcoFalke)
    • #24170 (p2p, rpc: Manual block-relay-only connections with addnode by mzumsande)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. DrahtBot cross-referenced this on Jul 12, 2022 from issue net, test: Virtualise CConnman and add initial PeerManager unit tests by dergoegge
  9. DrahtBot cross-referenced this on Jul 12, 2022 from issue net: Use serialization parameters for CAddress serialization by MarcoFalke
  10. DrahtBot cross-referenced this on Jul 12, 2022 from issue p2p, rpc: Manual block-relay-only connections with addnode by mzumsande
  11. dergoegge commented at 2:55 PM on July 12, 2022: member

    ACK fa4be8e7c324835d3b9eecb5a3825a4c8f77fb2f

  12. MarcoFalke merged this on Jul 12, 2022
  13. MarcoFalke closed this on Jul 12, 2022
  14. MarcoFalke deleted the branch on Jul 12, 2022
  15. sidhujag referenced this in commit ca188c8109 on Jul 12, 2022
  16. bitcoin deleted a comment on Jul 13, 2022
  17. bitcoin locked this on Jul 13, 2022
Contributors
MarcoFalkeDrahtBotdergoegge
Labels
RefactoringTests
Linked (view graph)
#25514 net processing: Move CNode::nServices and CNode::nLocalServices to Peer
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC