Currently GetTimeMillis is used for bench logging in milliseconds integral precision. Replace it to use a steady clock that is type-safe and steady.
Microsecond or float precision can be done in a follow-up.
Use steady clock for all millis bench logging #25499
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2206-steady-🏑 changing 8 files +18 −20-
MarcoFalke commented at 7:48 AM on June 29, 2022: member
- DrahtBot added the label Refactoring on Jun 29, 2022
-
DrahtBot commented at 11:56 AM on June 29, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #25830 (refactor: Replace m_params with chainman.GetParams() by aureleoules)
- #25665 (refactor: Add util::Result failure values, multiple error and warning messages by ryanofsky)
- #25284 ([WIP] consensus: Remove dependency on net (BIP 155 / ADDRV2_FORMAT) by MarcoFalke)
- #18904 (Don't call lsn_reset in periodic flush by bvbfan)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- MarcoFalke cross-referenced this on Jun 29, 2022 from issue [kernel 3b/n] Decouple `{Dump,Load}Mempool` from `ArgsManager` by dongcarl
- DrahtBot cross-referenced this on Jun 29, 2022 from issue refactor: Reduce number of LoadChainstate parameters and return values by ryanofsky
- DrahtBot cross-referenced this on Jun 29, 2022 from issue net: Use serialization parameters for CAddress serialization by MarcoFalke
- DrahtBot cross-referenced this on Jun 30, 2022 from issue Don't call lsn_reset in periodic flush by bvbfan
- DrahtBot cross-referenced this on Jun 30, 2022 from issue Improve runtime performance of --reindex by LarryRuane
- DrahtBot cross-referenced this on Jun 30, 2022 from issue Severity-based logging -- parent PR by jonatack
- DrahtBot cross-referenced this on Jul 8, 2022 from issue refactor: Make mapBlocksUnknownParent local, and rename it by LarryRuane
- MarcoFalke force-pushed on Jul 19, 2022
- DrahtBot added the label Needs rebase on Jul 20, 2022
- MarcoFalke force-pushed on Jul 20, 2022
- DrahtBot removed the label Needs rebase on Jul 20, 2022
- DrahtBot cross-referenced this on Jul 21, 2022 from issue refactor: Add util::Result failure values, multiple error and warning messages by ryanofsky
- DrahtBot cross-referenced this on Jul 27, 2022 from issue refactor: Use util::Result class for wallet loading by ryanofsky
- DrahtBot cross-referenced this on Jul 27, 2022 from issue refactor: Replace BResult with util::Result by ryanofsky
- DrahtBot added the label Needs rebase on Jul 29, 2022
-
Use steady clock for all millis bench logging fa521c9603
- MarcoFalke force-pushed on Jul 30, 2022
- DrahtBot removed the label Needs rebase on Jul 30, 2022
- DrahtBot cross-referenced this on Aug 13, 2022 from issue refactor: Replace m_params with chainman.GetParams() by aureleoules
- MarcoFalke cross-referenced this on Aug 18, 2022 from issue refactor: Make adjusted time type safe by MarcoFalke
- DrahtBot cross-referenced this on Sep 1, 2022 from issue refactor: Replace `std::optional<bilingual_str>` with `util::Result` by ryanofsky
- fanquake approved
-
fanquake commented at 9:26 AM on September 16, 2022: member
ACK fa521c960337a65d4ce12cd1ef009c652ffe57e6 - started making the same change.
- fanquake merged this on Sep 16, 2022
- fanquake closed this on Sep 16, 2022
- MarcoFalke deleted the branch on Sep 16, 2022
- sidhujag referenced this in commit 335124cf84 on Sep 20, 2022
- bitcoin locked this on Sep 16, 2023
