p2p: Set CNode::m_relays_txs=true when receiving BIP37 filters #25446

pull dergoegge wants to merge 1 commits into bitcoin:master from dergoegge:2022-06-22778-fix changing 1 files +1 −0
  1. dergoegge commented at 9:16 AM on June 22, 2022: member

    This line was accidentally removed in #22778.

    Receiving a filterload message implies that we should relay txs to the sender (CNode::m_relays_txs = true). CNode::m_relays_txs is only used for the inbound eviction logic, so removing the line might have slightly changed the eviction behaviour but nothing else.

  2. [net processing] Set CNode::m_relays_txs=true when receiving BIP37 filters
    This line was accidentally removed in #22778.
    e7a9133766
  3. fanquake added the label P2P on Jun 22, 2022
  4. dergoegge renamed this:
    [net processing] Set CNode::m_relays_txs=true when receiving BIP37 filters
    p2p: Set CNode::m_relays_txs=true when receiving BIP37 filters
    on Jun 22, 2022
  5. laanwj commented at 11:32 AM on June 22, 2022: member

    I see, it was removed here: https://github.com/bitcoin/bitcoin/pull/22778/files#diff-6875de769e90cec84d2e8a9c1b962cdbcda44d870d42e4215827e599e11e90e3R4090

    Code review ACK e7a9133766a2dc357a79d38cd47231cc99cdefb7

  6. vasild approved
  7. vasild commented at 12:13 PM on June 22, 2022: contributor

    ACK e7a9133766a2dc357a79d38cd47231cc99cdefb7

    So it actually happened that the redundant fields CNode::m_relays_txs and Peer::TxRelay::m_relay_txs went out of sync (one is true while the other is false) :-(

  8. dergoegge cross-referenced this on Jun 22, 2022 from issue refactor: Introduce EvictionManager by dergoegge
  9. DrahtBot commented at 5:25 PM on June 22, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25268 (refactor: Introduce EvictionManager by dergoegge)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  10. fanquake merged this on Jun 23, 2022
  11. fanquake closed this on Jun 23, 2022

  12. sidhujag referenced this in commit 4c520d1677 on Jun 27, 2022
  13. jnewbery commented at 8:27 AM on June 29, 2022: member

    post-merge ACK e7a9133766a2dc357a79d38cd47231cc99cdefb7

    Thanks @dergoegge!

  14. bitcoin locked this on Jun 29, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:53 UTC