Block announcements via headers may have up to MAX_BLOCKS_TO_ANNOUNCE = 8 entries according to the definition of this constant.
However, there are a few spots saying they should have a size less than MAX_BLOCKS_TO_ANNOUNCE. Fix these.
I don't think that this is critical (this only changes behavior when we get a headers announcement with exactly MAX_BLOCKS_TO_ANNOUNCE blocks which we can't connect), but it would be nice to handle this limit consistently.
p2p, doc: Use MAX_BLOCKS_TO_ANNOUNCE consistently #25404
pull mzumsande wants to merge 1 commits into bitcoin:master from mzumsande:202206_max_block_announce changing 1 files +3 −3-
mzumsande commented at 8:44 PM on June 17, 2022: contributor
-
e357c89538
p2p, doc: Use MAX_BLOCKS_TO_ANNOUNCE consistently
It is an inclusive upper bound according to its definition.
- fanquake added the label P2P on Jun 17, 2022
-
ghost commented at 12:41 AM on June 18, 2022: none
LGTM
- Raulnori77 approved
-
DrahtBot commented at 2:28 AM on June 18, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #25454 (p2p, refactor: Avoid multiple getheaders messages in flight to the same peer by sdaftuar)
- #24571 (p2p: Prevent block index fingerprinting by sending additional getheaders messages by dergoegge)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Jun 18, 2022 from issue p2p: Prevent block index fingerprinting by sending additional getheaders messages by dergoegge
- krissmkii approved
-
dergoegge commented at 12:53 PM on June 21, 2022: member
utACK e357c8953880715a943b892deed04e7777187999 - This PR makes the usage and docs of
MAX_BLOCKS_TO_ANNOUNCEconsistent with its description. - DrahtBot cross-referenced this on Jun 23, 2022 from issue p2p: Avoid multiple getheaders messages in flight to the same peer by sdaftuar
-
- fanquake merged this on Jun 27, 2022
- fanquake closed this on Jun 27, 2022
- mzumsande deleted the branch on Jun 27, 2022
- sidhujag referenced this in commit 81c71b6b52 on Jun 27, 2022
- bitcoin locked this on Jun 27, 2023
