BIP 37 protocol incompatibility #2534

issue jgarzik opened this issue on April 15, 2013

jgarzik commented at 6:32 PM on April 15, 2013: contributor

https://en.bitcoin.it/wiki/BIP_0037 states that "version" P2P message is extended by one byte. bitcoind's code appears to read this,

        if (!vRecv.empty())
            vRecv >> pfrom->fRelayTxes; // set to true after we get the first fi
lter* message
        else
            pfrom->fRelayTxes = true;

but does not appear to send the fRelayTxes byte:

    PushMessage("version", PROTOCOL_VERSION, nLocalServices, nTime, addrYou, addrMe,
                nLocalHostNonce, FormatSubVersion(CLIENT_NAME, CLIENT_VERSION, std::vector<string>()), nBestHeight);

rebroad commented at 12:51 AM on April 22, 2013: contributor

How is this an incompatibility?
bitsofproof cross-referenced this on Jun 11, 2013 from issue Send tx relay flag with version message by bitsofproof
sipa commented at 8:45 AM on June 17, 2013: member

Fixed by #2763
sipa closed this on Jun 17, 2013
luke-jr referenced this in commit 4ca705ac04 on Feb 1, 2016
luke-jr cross-referenced this on Feb 1, 2016 from issue Promote Draft->Final BIPs: 50, 60, 64, 66, and 73 by luke-jr
luke-jr cross-referenced this on Feb 24, 2016 from issue Promote Draft->Final BIPs: 60 and 64 by luke-jr
bitcoin locked this on Sep 8, 2021

Contributors

jgarzik

rebroad

sipa

Linked (view graph)

#2763 Send tx relay flag with version message