refactor: add most of src/util to iwyu #25324

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:src_util_iwyu changing 25 files +82 −29
  1. fanquake commented at 5:34 PM on June 9, 2022: member

    These files change infrequently, and not much header shuffling is required.

    We don't add everything in src/util/ yet, because IWYU makes some dubious suggestions, which I'm going to follow up with upstream.

    Soon we'll swap src/util/xyz.cpp for just src/util/.

  2. hebasto commented at 5:34 PM on June 9, 2022: member

    Concept ACK.

  3. DrahtBot commented at 6:37 PM on June 9, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25112 (util: Move error message formatting of NonFatalCheckError to cpp by MarcoFalke)
    • #24058 (BIP-322 basic support by kallewoof)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot added the label Refactoring on Jun 9, 2022
  5. DrahtBot added the label Utils/log/libs on Jun 9, 2022
  6. DrahtBot cross-referenced this on Jun 9, 2022 from issue Handle invalid hex encoding in ParseHex by MarcoFalke
  7. DrahtBot cross-referenced this on Jun 9, 2022 from issue refactor: Split util/system into exception, shell, and fs-specific files by Empact
  8. DrahtBot cross-referenced this on Jun 9, 2022 from issue util: Move error message formatting of NonFatalCheckError to cpp by MarcoFalke
  9. DrahtBot cross-referenced this on Jun 10, 2022 from issue refactor: Make FEELER_SLEEP_WINDOW type safe (std::chrono) by MarcoFalke
  10. DrahtBot cross-referenced this on Jun 10, 2022 from issue BIP-322 basic support by kallewoof
  11. DrahtBot cross-referenced this on Jun 29, 2022 from issue compat: document code in compat.h by fanquake
  12. DrahtBot cross-referenced this on Jul 1, 2022 from issue [kernel 3c/n] Decouple validation cache initialization from `ArgsManager` by dongcarl
  13. DrahtBot cross-referenced this on Jul 6, 2022 from issue fuzz: add low-level target for txorphanage by chinggg
  14. DrahtBot added the label Needs rebase on Jul 7, 2022
  15. in ci/test/06_script_b.sh:61 in fbdca5e024 outdated
      55 | +          " src/util/moneystr.cpp"\
      56 | +          " src/util/serfloat.cpp"\
      57 | +          " src/util/spanparsing.cpp"\
      58 | +          " src/util/strencodings.cpp"\
      59 | +          " src/util/syserror.cpp"\
      60 | +          " src/util/url.cpp"\
    


    hebasto commented at 5:37 PM on July 7, 2022:

    Actually, this PR affects more files, e.g., asmap.cpp, readwritefile.cpp etc. Should they be listed here as well?


    fanquake commented at 10:07 AM on July 8, 2022:

    IWYU generates spurious output for some .cpp files, which would require adding headers that I'm not sure are correct, so I've excluded them for now.

  16. refactor: add most of src/util to iwyu
    These files change infrequently, and not much header shuffling is required.
    
    We don't add everything in src/util/ yet, because IWYU makes some
    dubious suggestions, which I'm going to follow up with upstream.
    07f2c25d04
  17. fanquake force-pushed on Jul 8, 2022
  18. hebasto approved
  19. hebasto commented at 10:27 AM on July 8, 2022: member

    ACK 07f2c25d04c39a0074e1d9ee1b24b3e359c8153f, I have reviewed the code and it looks OK, I agree it can be merged.

    Suggesting to apply clang-format-diff.py as well.

  20. DrahtBot removed the label Needs rebase on Jul 8, 2022
  21. MarcoFalke merged this on Jul 12, 2022
  22. MarcoFalke closed this on Jul 12, 2022

  23. fanquake deleted the branch on Jul 12, 2022
  24. sidhujag referenced this in commit 4a524573ff on Jul 13, 2022
  25. bitcoin locked this on Sep 7, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC