normalize PSBT entry instead of external signer master fingerprint #25032

pull scgbckbone wants to merge 1 commits into bitcoin:master from scgbckbone:upper_master_fp_cor_cmp changing 1 files +4 −1

scgbckbone commented at 3:37 PM on April 29, 2022: none

Some external signers scripts may provide master fingerprint in uppercase format. In that case core will fail with Signer fingerprint 00000000 does not match any of the inputs as it only works with lowercase format. Even if the fingerprints match, yet one is lowercase the other uppercase.

Core can instead normalize fingerprint from PSBT and check both upper/lower case hex representation

Very similar to #25019 but no changing of fingerprint from external signer.
normalize PSBT entry instead of external signer master fingerprint - but check both upper/lower hex representation bfd7a98ea1
scgbckbone cross-referenced this on Apr 29, 2022 from issue add explicit condition fo master fingerprint to be lowercase hex by scgbckbone
scgbckbone cross-referenced this on Apr 29, 2022 from issue parse external signer master fp as bytes in ExternalSigner::SignTransaction by scgbckbone
scgbckbone commented at 11:06 PM on April 29, 2022: none

closing this in favor of https://github.com/bitcoin/bitcoin/pull/25019
scgbckbone closed this on Apr 29, 2022
bitcoin locked this on Apr 29, 2023

Contributors