Remove not needed clang-format off comments #24959

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2204-no-format-off-🔝 changing 11 files +180 −226
  1. MarcoFalke commented at 2:37 PM on April 24, 2022: member

    It seems odd to disable clang-format and force manual formatting when there is no need for it. So remove the clang-format comments and other unneeded comments.

    Can be reviewed with --word-diff-regex=. --ignore-all-space

    Looks like this was initially added in commit d9d79576f423cd9c5cef4547c7e3648dbb339460 to accommodate a linter that has since been removed and replaced by a functional test.

  2. MarcoFalke added the label Refactoring on Apr 24, 2022
  3. DrahtBot commented at 12:58 AM on April 25, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #23549 (Add scanblocks RPC call (attempt 2) by jamesob)
    • #23417 (wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager by achow101)
    • #23387 (WIP: add support to save fee estimates without having to shut down the node by greenaddress)
    • #22751 (rpc/wallet: add simulaterawtransaction RPC by kallewoof)
    • #19792 (rpc: Add dumpcoinstats by fjahr)
    • #19602 (wallet: Migrate legacy wallets to descriptor wallets by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot cross-referenced this on Apr 25, 2022 from issue [Draft / POC] Silent Payments by w0xlt
  5. DrahtBot cross-referenced this on Apr 25, 2022 from issue add RPC (-regtest only) for testing package policy by glozow
  6. DrahtBot cross-referenced this on Apr 25, 2022 from issue Add a "tx output spender" index by sstone
  7. MarcoFalke force-pushed on Apr 25, 2022
  8. DrahtBot cross-referenced this on Apr 25, 2022 from issue rpc: add rpc to get mempool txs spending specific prevouts by t-bast
  9. Remove not needed clang-format off comments
    Can be reviewed with --word-diff-regex=. --ignore-all-space
    fa870e3d4c
  10. DrahtBot cross-referenced this on Apr 25, 2022 from issue rpc: add require_checksum flag to deriveaddresses by kallewoof
  11. vincenzopalazzo approved
  12. MarcoFalke force-pushed on Apr 25, 2022
  13. DrahtBot cross-referenced this on Apr 25, 2022 from issue Add scanblocks RPC call (attempt 2) by jamesob
  14. DrahtBot cross-referenced this on Apr 25, 2022 from issue wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager by achow101
  15. DrahtBot cross-referenced this on Apr 25, 2022 from issue WIP: add support to save fee estimates without having to shut down the node by greenaddress
  16. DrahtBot cross-referenced this on Apr 25, 2022 from issue rpc: Return fee and prevout (utxos) to getrawtransaction by dougEfresh
  17. MarcoFalke commented at 1:02 PM on April 25, 2022: member

    Force pushed to remove an empty line

  18. DrahtBot cross-referenced this on Apr 26, 2022 from issue rpc/wallet: add simulaterawtransaction RPC by kallewoof
  19. DrahtBot cross-referenced this on Apr 26, 2022 from issue rpc: Add dumpcoinstats by fjahr
  20. fanquake approved
  21. fanquake commented at 9:51 AM on April 26, 2022: member

    ACK fa870e3d4ccd6dfd0a9a8f2c608721a7251114e2

  22. DrahtBot cross-referenced this on Apr 26, 2022 from issue wallet: Migrate legacy wallets to descriptor wallets by achow101
  23. laanwj commented at 1:09 PM on April 26, 2022: member

    Code review ACK fa870e3d4ccd6dfd0a9a8f2c608721a7251114e2

    Looks like this was initially added in commit https://github.com/bitcoin/bitcoin/commit/d9d79576f423cd9c5cef4547c7e3648dbb339460 to accommodate a linter

    Yes, also the table used to have more columns, so the grid based formatting helped make it legible.

  24. laanwj merged this on Apr 26, 2022
  25. laanwj closed this on Apr 26, 2022

  26. sidhujag referenced this in commit 86f62810e1 on Apr 26, 2022
  27. MarcoFalke deleted the branch on Apr 27, 2022
  28. bitcoin locked this on Apr 27, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC