This PR enables one more of the non-wallet functional tests (feature_fee_estimation.py) to be run even with the Bitcoin Core wallet disabled by using the MiniWallet instead, as proposed in #20078. It takes use of the recently introduced methods {create,send}_self_transfer_multi (#24637) which allows to specify multiple UTXOs to be spent rather than only one. Very likely the test can still be simplified (e.g. coin selection in small_txpuzzle_randfee), but this is a first step.
test: use MiniWallet for feature_fee_estimation.py #24817
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202204-test-use_MiniWallet_for_feature_fee_estimation changing 1 files +35 −70-
theStack commented at 12:23 AM on April 10, 2022: contributor
-
494455f8a5
test: use MiniWallet for feature_fee_estimation.py
This test can now be run even with the Bitcoin Core wallet disabled.
- DrahtBot added the label Tests on Apr 10, 2022
-
ayush933 commented at 1:02 PM on April 10, 2022: contributor
tACK 494455f8 . The test runs successfully with the wallet disabled.
- vincenzopalazzo approved
-
vincenzopalazzo commented at 11:22 PM on April 10, 2022: none
- badhikar approved
- MarcoFalke merged this on Apr 11, 2022
- MarcoFalke closed this on Apr 11, 2022
- theStack deleted the branch on Apr 11, 2022
- sidhujag referenced this in commit 06add764f5 on Apr 11, 2022
- mzumsande cross-referenced this on Apr 11, 2022 from issue Intermittent failure in feature_fee_estimation.py by mzumsande
-
- theStack cross-referenced this on Apr 22, 2022 from issue test: MiniWallet: support skipping mempool checks (feature_fee_estimation.py performance fix) by theStack
- shommel cross-referenced this on Apr 22, 2022 from issue test: Convert non-wallet tests to use our python MiniWallet by MarcoFalke
- MarcoFalke referenced this in commit d24318a40c on May 3, 2022
- sidhujag referenced this in commit 1e4a8f3ce3 on May 4, 2022
- bitcoin locked this on Apr 11, 2023
Contributors
Labels