This change is required for bitcoin/bitcoin#24773 as it prevents MSVC yelling about "warning C4551: function call missing argument list".
But it is useful by itself as it makes code more concise and readable.
refactor: Use [[maybe_unused]] attribute #24772
pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:220405-void changing 1 files +4 −12-
hebasto commented at 11:57 AM on April 5, 2022: member
-
55e0fc8df9
refactor: Drop unneeded workarounds aimed to silence unused warning
All of the touched symbols are indeed used regardless of any macros.
-
refactor: Use [[maybe_unused]] attribute 07ddecb84e
- fanquake added the label Refactoring on Apr 5, 2022
- hebasto cross-referenced this on Apr 5, 2022 from issue Enable HW-accelerated implementations of SHA256 for MSVC builds by hebasto
- vincenzopalazzo approved
-
vincenzopalazzo commented at 2:53 PM on April 6, 2022: none
-
Empact commented at 3:25 PM on April 6, 2022: member
Code review ACK 07ddecb84e6097684fa56cfc79c8c2aad76f6604
- w0xlt approved
-
w0xlt commented at 3:32 PM on April 6, 2022: contributor
ACK 07ddecb
-
laanwj commented at 1:58 PM on April 19, 2022: member
Code review ACK 07ddecb84e6097684fa56cfc79c8c2aad76f6604
- laanwj merged this on Apr 19, 2022
- laanwj closed this on Apr 19, 2022
- hebasto deleted the branch on Apr 19, 2022
- sidhujag referenced this in commit f308cdc773 on Apr 19, 2022
- str4d cross-referenced this on Jul 15, 2022 from issue Backport more recent SHA-256 assembly optimisations by str4d
- bitcoin locked this on Apr 19, 2023
