test: -peerblockfilters without -blockfilterindex raises an error #24698

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2022-03-peerblockfilters-init-error changing 1 files +6 −0

brunoerg commented at 7:55 PM on March 28, 2022: contributor

This PR adds test coverage for the following init error: https://github.com/bitcoin/bitcoin/blob/2a3e8fb3592e42300ec96c9f6724e15346e30ea7/src/init.cpp#L850

Setting -peerblockfilters without -blockfilterindex should raise an error when initializing.
test: -peerblockfilters without -blockfilterindex raises an error d6bc2322ed
fanquake added the label Tests on Mar 28, 2022
ccdle12 commented at 3:34 PM on March 30, 2022: contributor

Tested ACK https://github.com/bitcoin/bitcoin/pull/24698/commits/d6bc2322ed2e0674e027d39825fdadbb0db2c24a
MarcoFalke merged this on Mar 31, 2022
MarcoFalke closed this on Mar 31, 2022
jonatack commented at 2:32 PM on March 31, 2022: contributor

Post-merge ACK (proposed a couple years ago in #19720, it was acked but never merged)
MarcoFalke cross-referenced this on Mar 31, 2022 from issue test: p2p_blockfilters tests for BIP157 config args by robot-dreams
sidhujag referenced this in commit 3d9ab8b467 on Apr 3, 2022
bitcoin locked this on Mar 31, 2023

Contributors

Labels