build, qt: drop fix_no_printer patch, add CVE fixes #24688

pull prusnak wants to merge 3 commits into bitcoin:master from prusnak:qt5-5.15.3+patches changing 12 files +191 −200

prusnak commented at 10:20 AM on March 27, 2022: contributor
- builds on top of #24668, hence the draft state
- contains fix from #24684
- adds 2 CVE fixes mentioned in https://github.com/bitcoin/bitcoin/pull/24668

build, qt: bump Qt5 version to 5.15.3

Qt 5.15.3 release is a patch release made on the top of Qt 5.15.2. As a patch
release, Qt 5.15.3 does not add any new functionality but provides bug fixes
and other improvements.

https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/5.15.3/release-note.md

* dropped patches:
  - patches/qt/dont_use_avx_android_x86_64.patch
  - patches/qt/fix_bigsur_style.patch
* adjusted patches:
  - patches/qt/fix_android_jni_static.patch
  - patches/qt/fix_limits_header.patch
  - patches/qt/use_android_ndk23.patch

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

7cbeee9ffc

build, qt: Drop fix_no_printer.patch

The removed patch is not required since switching Qt version from
5.12.11 to 5.15.2.

34d469affe

build, qt: add fixes for CVE-2022-25255 and CVE-2022-25634

more info:
- https://nvd.nist.gov/vuln/detail/CVE-2022-25255
- https://nvd.nist.gov/vuln/detail/CVE-2022-25634

patches adapted from:
- https://download.qt.io/official_releases/qt/5.15/CVE-2022-25255-qprocess5-15.diff
- https://download.qt.io/official_releases/qt/5.15/CVE-2022-25643-5.15.diff

note: there is a typo in the second upstream patch filename :-/
      (should be 25634, is 25643)

8d83d31ed9

prusnak renamed this:
~~build, qt: drop fix_no_printer patch, add~~
build, qt: drop fix_no_printer patch, add CVE fixes
on Mar 27, 2022
prusnak cross-referenced this on Mar 27, 2022 from issue build, qt: bump Qt5 version to 5.15.3 by prusnak
prusnak cross-referenced this on Mar 27, 2022 from issue build, qt: Drop fix_no_printer.patch by hebasto
fanquake commented at 10:36 AM on March 27, 2022: member

NACK. I don't understand why all these Qt patch changes are being split into different PRs. If we are going to go through the motions of bumping Qt, then all the changes should be in #24668.
prusnak commented at 10:39 AM on March 27, 2022: contributor

NACK.

This PR is a combination of all Qt related PRs. If our goal is to have all changes combined, I can just push the same changeset to #24668 and close this PR.
fanquake commented at 10:44 AM on March 27, 2022: member

If our goal is to have all changes combined, I can just push the same changeset to #24668 and close this PR.

Yes, lets do that.
prusnak commented at 10:47 AM on March 27, 2022: contributor

Yes, lets do that.

Done. Closing this PR. Sorry for the noise.

2 extra commits from this PR pushed to #24668
prusnak closed this on Mar 27, 2022
prusnak deleted the branch on Mar 27, 2022
bitcoin locked this on Mar 27, 2023

Contributors

prusnak

fanquake

Linked (view graph)

#24668 build, qt: bump Qt5 version to 5.15.3 #24684 build, qt: Drop fix_no_printer.patch