IsStandard should check the witnessprogram is a valid point on the field #24631

issue junderw opened this issue on March 21, 2022
  1. junderw commented at 11:39 PM on March 21, 2022: contributor

    Is your feature request related to a problem? Please describe. A v1 taproot witness program must be a valid point on secp256k1 otherwise it is essentially a black hole.

    Describe the solution you'd like Add a check in IsStandard that will check the witnessprogram in the case where WITNESS_V1 is returned. If the witness program is not the X value of a valid point, return false. (https://github.com/bitcoin/bitcoin/blob/v22.0/src/policy/policy.cpp#L53-L74)

  2. junderw added the label Feature on Mar 21, 2022
  3. junderw cross-referenced this on Mar 21, 2022 from issue Misc. improvements and cleanups by brandonblack
  4. theStack commented at 12:02 AM on March 22, 2022: contributor

    There has been a pull request with that policy change already (#24106), but it was rejected with quite convincing reasons, e.g. potential problems in batching transactions for exchanges. See in particular the answers #24106 (comment), #24106 (comment) and #24106 (comment).

  5. junderw closed this on Mar 22, 2022

  6. bitcoin locked this on Mar 22, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:53 UTC