Looks like there is no test for diamonds, only for chains (in mempool_packages.py)
test: Add diamond-shape prioritisetransaction test #24623
pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2203-test-diamond-👟 changing 2 files +87 −3-
MarcoFalke commented at 10:11 AM on March 21, 2022: member
- fanquake added the label Tests on Mar 21, 2022
-
jessebarton commented at 1:17 AM on March 23, 2022: contributor
Concept ACK fa58577
Test passed, no issues
I'm still learning quite a bit, so not sure what else to check for. Looking at the prioritisetransaction function and trying to understand the logic.
If reviews like this aren't helpful let me know.
- MarcoFalke force-pushed on Mar 24, 2022
- MarcoFalke cross-referenced this on Mar 24, 2022 from issue test: use MiniWallet for mempool_package_onemore.py by theStack
-
fa450c18db
test: Rework create_self_transfer_multi
* Add fallback for utxos_to_spend if none are provided * Refactor a for-loop
-
test: Add diamond-shape prioritisetransaction test fa0758e145
- MarcoFalke force-pushed on Mar 24, 2022
-
MarcoFalke commented at 5:15 PM on March 24, 2022: member
Rebased for minor rework
-
jamesob commented at 4:34 PM on March 25, 2022: member
ACK https://github.com/bitcoin/bitcoin/pull/24623/commits/fa0758e1457552e9243bc9663408e88a8cccc8f6
Nice test! Ran locally. Was this motivated by the oversight in #24364?
-
MarcoFalke commented at 4:45 PM on March 25, 2022: member
This probably can't catch #24364 in the current form. I'd suspect there will need to be at least one call to
getblocktemplate - MarcoFalke merged this on Mar 28, 2022
- MarcoFalke closed this on Mar 28, 2022
- MarcoFalke deleted the branch on Mar 28, 2022
- sidhujag referenced this in commit ba62e21b86 on Apr 3, 2022
- bitcoin locked this on Mar 28, 2023
