doc: mention that BDB is for the legacy wallet in build-freebsd.md #24600

1. 
   fanquake commented at 11:07 AM on March 17, 2022: member

   Re-order legacy and descriptor wallet section. Remove prelude that pointlessly repeats the same info. Cleanup configure examples.

   FreeBSD version of #23446.

2. fanquake added the label Docs on Mar 17, 2022
3. fanquake added the label Linux/Unix on Mar 17, 2022
4. fanquake cross-referenced this on Mar 18, 2022 from issue doc: consolidate legacy wallet documentation by fanquake
5. its0x08 approved
6. DrahtBot added the label Needs rebase on Mar 23, 2022
7. fanquake force-pushed on Mar 23, 2022
8. 
   fanquake commented at 1:19 PM on March 23, 2022: member

   Rebased past #24646.

9. fanquake requested review from laanwj on Mar 23, 2022
10. DrahtBot removed the label Needs rebase on Mar 23, 2022
11. doc: mention that BDB is for the legacy wallet in build-freebsd.md

    Re-order legacy and descriptor wallet section.
    Remove prelude that pointlessly reqpeats the same info.
    Cleanup configure examples.

    b5ba3b5b2c
12. fanquake force-pushed on Mar 23, 2022
13. 
    amogyisabogy1 commented at 4:59 PM on March 23, 2022: none

    Mentioning BDB is for legacy wallets would be beneficial

14. 
    fanquake commented at 5:19 PM on March 24, 2022: member

    @shaavan would you like to review this?

15. shaavan approved
16. 
    shaavan commented at 7:25 AM on March 25, 2022: contributor

    ACK b5ba3b5b2cbec4db94037baad960410fe98f3fdd

    I like the idea of moving sections talking about descriptor wallets (about adding support and compiling) before legacy wallets because:

    1. We want to encourage users to build a descriptor wallet over the legacy wallet. And talking about descriptor wallet first is one way to do so.
    2. It maintains consistency with other updated documentation, prioritized for the descriptor wallet over the legacy wallet.

    I verified that:

    1. Links for FreeBSD and descriptor wallet direct to the correct webpage and documentation, respectively.
    2. The code corresponding to installing db5 and compiling descriptor wallet and GUI (a move-only change) is correct.
17. fanquake merged this on Mar 25, 2022
18. fanquake closed this on Mar 25, 2022

    ---

19. fanquake deleted the branch on Mar 25, 2022
20. sidhujag referenced this in commit 8470308f80 on Apr 2, 2022
21. bitcoin locked this on Mar 25, 2023

Contributors

fanquakeits0x08amogyisabogy1shaavan

Review Requested
laanwj