Move txoutproof RPCs to txoutproof.cpp #24582

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2203-txoutproof-move-🍤 changing 4 files +186 −160
  1. MarcoFalke commented at 11:01 AM on March 16, 2022: member

    The txoutproof RPCs don't really fit into rawtransaction.cpp, as they deal with txids, not with raw transactions. As they are placed in the blockchain RPC category, they could be moved there. However, blockchain.cpp already takes about 20 seconds to compile (and rawtransaction.cpp even longer), so move them to a separate file.

    Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space.

  2. MarcoFalke added the label Refactoring on Mar 16, 2022
  3. MarcoFalke added the label RPC/REST/ZMQ on Mar 16, 2022
  4. DrahtBot commented at 11:07 AM on March 16, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24539 (Add a "tx output spender" index by sstone)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. MarcoFalke force-pushed on Mar 16, 2022
  6. MarcoFalke marked this as a draft on Mar 16, 2022
  7. DrahtBot cross-referenced this on Mar 17, 2022 from issue Add a "tx output spender" index by sstone
  8. DrahtBot cross-referenced this on Mar 17, 2022 from issue Only load BlockMan in BlockMan member functions by dongcarl
  9. DrahtBot cross-referenced this on Mar 17, 2022 from issue blockman: Properly guard blockfile members by dongcarl
  10. DrahtBot added the label Needs rebase on Mar 17, 2022
  11. Move txoutproof RPCs to txoutproof.cpp fa2d176016
  12. MarcoFalke force-pushed on Mar 17, 2022
  13. DrahtBot removed the label Needs rebase on Mar 17, 2022
  14. MarcoFalke marked this as ready for review on Mar 18, 2022
  15. theStack approved
  16. theStack commented at 12:50 PM on March 20, 2022: contributor

    Concept and code-review ACK fa2d176016683eac82dabfbfc276b8a7b07b7499

  17. achow101 commented at 5:27 PM on March 23, 2022: member

    ACK fa2d176016683eac82dabfbfc276b8a7b07b7499

  18. fanquake merged this on Mar 23, 2022
  19. fanquake closed this on Mar 23, 2022
  20. sidhujag referenced this in commit d0f25038b4 on Mar 24, 2022
  21. MarcoFalke deleted the branch on Mar 24, 2022
  22. Fabcien referenced this in commit a091c2af52 on Jan 24, 2023
  23. bitcoin locked this on Mar 24, 2023
Contributors
MarcoFalkeDrahtBottheStackachow101
Labels
RefactoringRPC/REST/ZMQ
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC