remove explicit `descriptors=true` parameter for createwallet RPCs in functional tests #24550

issue theStack opened this issue on March 13, 2022
  1. theStack commented at 2:52 PM on March 13, 2022: contributor

    Since the default wallet type was changed to descriptor wallets in #23002, there is no need to explicitly pass the descriptors=true parameter to createwallet RPCs anymore. All of those instances in functional tests should be identified and simplified by omitting the parameter (there is already a PR doing the same for documentation, see #24519).

    Useful skills:

    • Basic Python3 knowledge

    Want to work on this issue?

    For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

  2. theStack cross-referenced this on Mar 13, 2022 from issue doc: update multisig-tutorial.md to descriptor wallet by default by jonatack
  3. theStack commented at 2:56 PM on March 13, 2022: contributor

    (Not sure if I have to explicitly mention this here or maintainers see it by the template I selected: this should get the "good first issue" tag).

  4. fanquake added the label good first issue on Mar 13, 2022
  5. prusnak cross-referenced this on Mar 13, 2022 from issue test: remove explicit descriptors=True for createwallet RPC calls by prusnak
  6. prusnak commented at 6:53 PM on March 13, 2022: contributor

    Implemented in https://github.com/bitcoin/bitcoin/pull/24551

  7. theStack commented at 1:51 PM on March 14, 2022: contributor

    My assumption that those parameters can be removed also in the test framework was wrong (see #24551 (comment) and #24551 (comment)), i.e. will close this now. Sorry for the noise!

  8. theStack closed this on Mar 14, 2022
  9. fanquake removed the label good first issue on Mar 14, 2022
  10. bitcoin locked this on Mar 14, 2023
Contributors
theStackprusnak
Linked (view graph)
#23002 Make descriptor wallets by default#24519 doc: update multisig-tutorial.md to descriptor wallet by default#24551 test: remove explicit descriptors=True for createwallet RPC calls
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC