init, doc: improve -onlynet help and related tor/i2p documentation #24468

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:onlynet-help-and-doc-improvements changing 4 files +11 −11

jonatack commented at 3:20 PM on March 3, 2022: contributor
including review feedback from #22834 (review) and #24205 (review) concerning src/init.cpp, doc/tor.md and doc/i2p.md
- s/outgoing/automatic outbound/
- s/Incoming/Inbound and manual/ (are not affected by this option.)
- s/only through network/only to network/
- s/this option. This option/this option. It/
- s/network types/networks/
and pick up a few nits in doc/p2p-bad-ports.md from #23542#pullrequestreview-881415043.

init, doc: improve -onlynet help and tor/i2p documentation

and harmonize them as follows

- s/outgoing/automatic outbound/
- s/Incoming/Inbound and manual/ (are not affected by this option.)
- s/only through network/only to network/
- s/this option. This option/this option. It/
- s/network types/networks/

and also pick up a few nits in doc/p2p-bad-ports.md

a1db99adea

jonatack cross-referenced this on Mar 3, 2022 from issue init, test: improve network reachability test coverage and safety by jonatack
jonatack cross-referenced this on Mar 3, 2022 from issue net: respect -onlynet= when making outbound connections by vasild
jonatack cross-referenced this on Mar 3, 2022 from issue net: open p2p connections to nodes that listen on non-default ports by vasild
DrahtBot added the label Docs on Mar 3, 2022
jonatack commented at 9:04 PM on March 3, 2022: contributor

Targets backport for v23.
w0xlt approved
w0xlt commented at 9:15 PM on March 3, 2022: contributor

ACK a1db99a
theStack approved
theStack commented at 9:20 AM on March 4, 2022: contributor

LGTM.

ACK a1db99adea36dbee1ec97ca1851edad12137feea
laanwj commented at 10:42 AM on March 7, 2022: member

ACK a1db99adea36dbee1ec97ca1851edad12137feea
laanwj merged this on Mar 7, 2022
laanwj closed this on Mar 7, 2022
jonatack deleted the branch on Mar 7, 2022
sidhujag referenced this in commit c561f58099 on Mar 7, 2022
jonatack cross-referenced this on Mar 9, 2022 from issue 23.x backports by jonatack
jonatack referenced this in commit 2a6fcf9c13 on Mar 13, 2022
hebasto referenced this in commit cb081896b2 on Mar 31, 2022
fanquake referenced this in commit c243e08351 on Mar 31, 2022
bitcoin locked this on Mar 7, 2023

Contributors

Labels

Linked (view graph)

#22834 net: respect -onlynet= when making outbound connections #23542 net: open p2p connections to nodes that listen on non-default ports #24205 init, test: improve network reachability test coverage and safety #24512 23.x backports