Clarifies sign conversion and allows to remove a file-wide suppression.
Also, includes an unrelated commit to remove unused suppressions.
refactor: Avoid implicit-integer-sign-change in bech32.cpp #24402
pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2202-intbech changing 2 files +3 −6-
MarcoFalke commented at 8:15 AM on February 21, 2022: member
- MarcoFalke added the label Refactoring on Feb 21, 2022
-
DrahtBot commented at 7:55 PM on February 21, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #24214 (Fix unsigned integer overflows in interpreter by MarcoFalke)
- #17786 (refactor: Nuke policy/fees->mempool circular dependencies by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Feb 21, 2022 from issue Fix unsigned integer overflows in interpreter by MarcoFalke
- DrahtBot cross-referenced this on Feb 22, 2022 from issue refactor: Nuke policy/fees->mempool circular dependencies by hebasto
-
test: Remove no longer needed suppressions fae6b26758
-
Avoid implicit-integer-sign-change in bech32.cpp aaaa4dbab4
- MarcoFalke force-pushed on Feb 25, 2022
- fanquake approved
-
fanquake commented at 1:08 PM on February 25, 2022: member
ACK aaaa4dbab4ec06d69645de919810ccd0da836a0e
- fanquake merged this on Feb 25, 2022
- fanquake closed this on Feb 25, 2022
- MarcoFalke deleted the branch on Feb 25, 2022
- sidhujag referenced this in commit e5da055515 on Feb 25, 2022
- bitcoin locked this on Feb 25, 2023
Contributors
Labels